chrome/browser/ui/website_settings/website_settings.h - Issue 2521173004: Remove SetSelectedTab() and deprecate unused WebsiteSettingsAction values.

Unified Diff: chrome/browser/ui/website_settings/website_settings.h

Issue 2521173004: Remove SetSelectedTab() and deprecate unused WebsiteSettingsAction values. (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/website_settings/website_settings.h

diff --git a/chrome/browser/ui/website_settings/website_settings.h b/chrome/browser/ui/website_settings/website_settings.h

index 7b9b4aca2e1297e929ed2ec8bc1e9f50b02d7e71..ad24be50558d68d150fbc29208759fea1ff7a5e3 100644

--- a/chrome/browser/ui/website_settings/website_settings.h

+++ b/chrome/browser/ui/website_settings/website_settings.h

@@ -89,9 +89,11 @@ class WebsiteSettings : public TabSpecificContentSettings::SiteDataObserver,

// GENERATED_JAVA_ENUM_PACKAGE: org.chromium.chrome.browser.pageinfo

enum WebsiteSettingsAction {

WEBSITE_SETTINGS_OPENED = 0,

- WEBSITE_SETTINGS_PERMISSIONS_TAB_SELECTED = 1,

- WEBSITE_SETTINGS_CONNECTION_TAB_SELECTED = 2,

- WEBSITE_SETTINGS_CONNECTION_TAB_SHOWN_IMMEDIATELY = 3,

+ // No longer used; indicated actions for to the old version of Page Info

msw 2016/11/29 18:26:03 nit: "for to"

lgarron 2016/12/16 05:46:59 Done.

+ // that had a "Permissions" tab and a "Connection" tab.

+ // WEBSITE_SETTINGS_PERMISSIONS_TAB_SELECTED = 1,

msw 2016/11/29 18:31:01 Do you need to remove usage from website_settings_

lgarron 2016/12/16 05:46:59 Done.

+ // WEBSITE_SETTINGS_CONNECTION_TAB_SELECTED = 2,

+ // WEBSITE_SETTINGS_CONNECTION_TAB_SHOWN_IMMEDIATELY = 3,

WEBSITE_SETTINGS_COOKIES_DIALOG_OPENED = 4,

WEBSITE_SETTINGS_CHANGED_PERMISSION = 5,

WEBSITE_SETTINGS_CERTIFICATE_DIALOG_OPENED = 6,

@@ -99,7 +101,9 @@ class WebsiteSettings : public TabSpecificContentSettings::SiteDataObserver,

// WEBSITE_SETTINGS_TRANSPARENCY_VIEWER_OPENED = 7,

WEBSITE_SETTINGS_CONNECTION_HELP_OPENED = 8,

WEBSITE_SETTINGS_SITE_SETTINGS_OPENED = 9,

- WEBSITE_SETTINGS_SECURITY_DETAILS_OPENED = 10,

+ // No longer used; opened the DevTools Security panel

msw 2016/11/29 18:26:03 nit: trailing period

lgarron 2016/12/16 05:46:59 Done.

+ // (or the certificate viewer, if DevTools was enabled.)

+ // WEBSITE_SETTINGS_SECURITY_DETAILS_OPENED = 10,

msw 2016/11/29 18:31:01 Do you need to remove usage from WebsiteSettingsPo

lgarron 2016/12/16 05:46:59 Hmm. I guess we want that metric to stick around w

WEBSITE_SETTINGS_COUNT

};