Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 252113004: [CSS Shapes] complex calc values for shape-margin return null for computed style (Closed)

Created:
6 years, 7 months ago by rwlbuis
Modified:
6 years, 7 months ago
CC:
blink-reviews, ed+blinkwatch_opera.com, ojan, dglazkov+blink, apavlov+blink_chromium.org, darktears, rune+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

[CSS Shapes] complex calc values for shape-margin return null for computed style We need to pass RenderStyle to the cssValuePool when parsing shape-margin in order to use calc() as a parameter. A new test case for this was added to parsing-shape-margin.html. This is a merge of http://trac.webkit.org/changeset/167935 by Zoltan Horvath <zoltan@webkit.org>;. BUG=368069 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=172930

Patch Set 1 #

Patch Set 2 : Remove webkit prefix #

Patch Set 3 : Fix expected result #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M LayoutTests/fast/shapes/parsing/parsing-shape-margin.html View 1 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/fast/shapes/parsing/parsing-shape-margin-expected.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/css/CSSComputedStyleDeclaration.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (0 generated)
rwlbuis
Assign to Zoltan for first look. I wonder if the WebKit ones have to go ...
6 years, 7 months ago (2014-04-29 14:47:14 UTC) #1
Zoltan
On 2014/04/29 14:47:14, rwlbuis wrote: > Assign to Zoltan for first look. I wonder if ...
6 years, 7 months ago (2014-04-29 15:47:04 UTC) #2
Zoltan
You might remove -webkit from the test.
6 years, 7 months ago (2014-04-29 15:47:36 UTC) #3
rwlbuis
On 2014/04/29 15:47:36, Zoltan wrote: > You might remove -webkit from the test. Oops! Fixed.
6 years, 7 months ago (2014-04-29 16:57:14 UTC) #4
rwlbuis
PTAL! This is fresh from WebKit side.
6 years, 7 months ago (2014-04-29 16:59:19 UTC) #5
leviw_travelin_and_unemployed
lgtm
6 years, 7 months ago (2014-04-29 17:08:48 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/252113004/20001
6 years, 7 months ago (2014-04-29 17:09:30 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-29 17:27:08 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel on tryserver.blink
6 years, 7 months ago (2014-04-29 17:27:09 UTC) #9
rwlbuis
The CQ bit was checked by rob.buis@samsung.com
6 years, 7 months ago (2014-04-29 17:33:55 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/252113004/40001
6 years, 7 months ago (2014-04-29 17:34:18 UTC) #11
rwlbuis
The CQ bit was checked by rob.buis@samsung.com
6 years, 7 months ago (2014-04-29 19:50:47 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/252113004/40001
6 years, 7 months ago (2014-04-29 19:52:01 UTC) #13
commit-bot: I haz the power
6 years, 7 months ago (2014-04-30 04:49:30 UTC) #14
Message was sent while issue was closed.
Change committed as 172930

Powered by Google App Engine
This is Rietveld 408576698