Source/core/css/CSSComputedStyleDeclaration.cpp - Issue 252113004: [CSS Shapes] complex calc values for shape-margin return null for computed style

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/CSSComputedStyleDeclaration.cpp

Issue 252113004: [CSS Shapes] complex calc values for shape-margin return null for computed style (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fix expected result Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/css/CSSComputedStyleDeclaration.cpp

diff --git a/Source/core/css/CSSComputedStyleDeclaration.cpp b/Source/core/css/CSSComputedStyleDeclaration.cpp

index 5bb5efa89c75dcf504b57630b01475a7988d5b99..7995215e1d5aca434924688783e022e42c57739e 100644

--- a/Source/core/css/CSSComputedStyleDeclaration.cpp

+++ b/Source/core/css/CSSComputedStyleDeclaration.cpp

@@ -2656,7 +2656,7 @@ PassRefPtrWillBeRawPtr<CSSValue> CSSComputedStyleDeclaration::getPropertyCSSValu

case CSSPropertyWebkitWrapFlow:

return cssValuePool().createValue(style->wrapFlow());

case CSSPropertyShapeMargin:

- return cssValuePool().createValue(style->shapeMargin());

+ return cssValuePool().createValue(style->shapeMargin(), *style);

case CSSPropertyShapeImageThreshold:

return cssValuePool().createValue(style->shapeImageThreshold(), CSSPrimitiveValue::CSS_NUMBER);

case CSSPropertyShapeOutside:

« no previous file with comments | « LayoutTests/fast/shapes/parsing/parsing-shape-margin-expected.txt ('k') | no next file » | no next file with comments »