[runtime] Fix call-site rendering for inlined calls.

[runtime] Fix call-site rendering for inlined calls.

This makes sure call-site rendering for certain {TypeError} messages is
based on the correct underlying {JSFunction}, even when inlined frames
are present. Only the {FrameSummary} knows the exact function.

R=verwaest@chromium.org
TEST=message/regress/regress-crbug-661579
BUG=chromium:661579
Committed: https://crrev.com/22a2ae07afbec087229119970d816788131cacd5
Cr-Commit-Position: refs/heads/master@{#41264}

[Michael Starzinger, 2016-11-23 13:43:38]

The CQ bit was checked by mstarzinger@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-23 13:43:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-23 14:10:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-23 14:10:55]

Dry run: This issue passed the CQ dry run.

[Toon Verwaest, 2016-11-24 12:37:45]

https://codereview.chromium.org/2521103005/diff/1/src/runtime/runtime-interna...
File src/runtime/runtime-internal.cc (right):

https://codereview.chromium.org/2521103005/diff/1/src/runtime/runtime-interna...
src/runtime/runtime-internal.cc:381: *target = MessageLocation(casted_script,
pos, pos + 1, function);
Mmh, shouldn't it be function->shared()->script() then, in case we have
cross-script inlining? I guess that's not guaranteed to have a script either in
case of manual builtin inlining?

[Michael Starzinger, 2016-11-24 12:53:42]

The CQ bit was checked by mstarzinger@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-24 12:53:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Michael Starzinger, 2016-11-24 12:53:52]

PTAL. Addressed comments.

https://codereview.chromium.org/2521103005/diff/1/src/runtime/runtime-interna...
File src/runtime/runtime-internal.cc (right):

https://codereview.chromium.org/2521103005/diff/1/src/runtime/runtime-interna...
src/runtime/runtime-internal.cc:381: *target = MessageLocation(casted_script,
pos, pos + 1, function);
On 2016/11/24 12:37:45, Toon Verwaest wrote:
> Mmh, shouldn't it be function->shared()->script() then, in case we have
> cross-script inlining? I guess that's not guaranteed to have a script either
in
> case of manual builtin inlining?

Done.

[Toon Verwaest, 2016-11-24 12:57:12]

lgtm, thanks!

[commit-bot: I haz the power, 2016-11-24 13:18:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-24 13:18:09]

Dry run: This issue passed the CQ dry run.

[Michael Starzinger, 2016-11-24 13:34:49]

The CQ bit was checked by mstarzinger@chromium.org

[commit-bot: I haz the power, 2016-11-24 13:34:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-24 13:36:31]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1479994489947080,
"parent_rev": "ee0abc5dd33cf83b7c8e325d7b5b81950b8c57a5", "commit_rev":
"93778043ed9a216f89f6e325766b7575a07e92b3"}

[commit-bot: I haz the power, 2016-11-24 13:36:36]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-24 13:36:57]

Description was changed from

==========
[runtime] Fix call-site rendering for inlined calls.

This makes sure call-site rendering for certain {TypeError} messages is
based on the correct underlying {JSFunction}, even when inlined frames
are present. Only the {FrameSummary} knows the exact function.

R=verwaest@chromium.org
TEST=message/regress/regress-crbug-661579
BUG=chromium:661579
==========

to

==========
[runtime] Fix call-site rendering for inlined calls.

This makes sure call-site rendering for certain {TypeError} messages is
based on the correct underlying {JSFunction}, even when inlined frames
are present. Only the {FrameSummary} knows the exact function.

R=verwaest@chromium.org
TEST=message/regress/regress-crbug-661579
BUG=chromium:661579

Committed: https://crrev.com/22a2ae07afbec087229119970d816788131cacd5
Cr-Commit-Position: refs/heads/master@{#41264}
==========

[commit-bot: I haz the power, 2016-11-24 13:36:58]

Patchset 2 (id:??) landed as
https://crrev.com/22a2ae07afbec087229119970d816788131cacd5
Cr-Commit-Position: refs/heads/master@{#41264}