Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 2521103004: Revert of Apply custom property animation (Closed)

Created:
4 years ago by kolos1
Modified:
4 years ago
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-css, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, Eric Willigers, rjwright, rwlbuis, shans
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Apply custom property animation (patchset #15 id:280001 of https://codereview.chromium.org/2309963002/ ) Reason for revert: Some browser tests fail. See crbug.com/668069 Original issue's description: > Apply custom property animations > > This change enables CSS and Web animations to apply animated > effects on CSS custom properties. > > This change involves a restructure of style resolving detailed > in the design doc: > https://docs.google.com/a/chromium.org/document/d/1V27q30H-pQZVbzHCJjdFThBSeuvxkGLdGmb1hLWBAiY > > BUG=644148 > > Committed: https://crrev.com/99118e5d645f046aa132529f6189a850c5b8ed49 > Cr-Commit-Position: refs/heads/master@{#434122} TBR=timloh@chromium.org,alancutter@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=644148 Committed: https://crrev.com/b7e89748bf097ebebc0f18a8270015b4eddc4508 Cr-Commit-Position: refs/heads/master@{#434139}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+166 lines, -528 lines) Patch
D third_party/WebKit/LayoutTests/animations/custom-properties/element-animate-crash.html View 1 chunk +0 lines, -25 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/custom-properties/unregistered-at-apply.html View 1 chunk +0 lines, -30 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/custom-properties/unregistered-element-animate.html View 1 chunk +0 lines, -19 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/custom-properties/unregistered-inheritance.html View 1 chunk +0 lines, -38 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/custom-properties/unregistered-simple.html View 1 chunk +0 lines, -32 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/custom-properties/unregistered-var-chain.html View 1 chunk +0 lines, -33 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/custom-properties/unregistered-var-in-keyframe.html View 1 chunk +0 lines, -41 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/custom-properties/value-tainting.html View 1 chunk +0 lines, -70 lines 0 comments Download
A third_party/WebKit/LayoutTests/animations/custom-property-animation-crash.html View 1 chunk +25 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/animations/custom-property-value-tainting.html View 1 chunk +70 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/animations/custom-property-value-tainting-expected.txt View 1 chunk +8 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/animation/EffectStack.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/EffectStack.cpp View 1 chunk +0 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/animation/css/CSSAnimations.h View 2 chunks +12 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/core/animation/css/CSSAnimations.cpp View 4 chunks +10 lines, -20 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/StyleResolver.h View 2 chunks +4 lines, -51 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp View 15 chunks +37 lines, -135 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/StyleResolverState.h View 2 chunks +0 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/StyleResolverState.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
kolos1
Created Revert of Apply custom property animation
4 years ago (2016-11-23 10:03:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2521103004/1
4 years ago (2016-11-23 10:03:49 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-23 10:04:56 UTC) #5
commit-bot: I haz the power
4 years ago (2016-11-23 10:07:22 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b7e89748bf097ebebc0f18a8270015b4eddc4508
Cr-Commit-Position: refs/heads/master@{#434139}

Powered by Google App Engine
This is Rietveld 408576698