Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(648)

Unified Diff: third_party/WebKit/Source/core/animation/css/CSSAnimations.cpp

Issue 2521103004: Revert of Apply custom property animation (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/animation/css/CSSAnimations.cpp
diff --git a/third_party/WebKit/Source/core/animation/css/CSSAnimations.cpp b/third_party/WebKit/Source/core/animation/css/CSSAnimations.cpp
index cd9517c12d0bc48412c11b966ca31bb5fa148c2b..fd942c0ca814fa5a684cec29291edad7f5f70445 100644
--- a/third_party/WebKit/Source/core/animation/css/CSSAnimations.cpp
+++ b/third_party/WebKit/Source/core/animation/css/CSSAnimations.cpp
@@ -231,15 +231,19 @@
return false;
}
-void CSSAnimations::calculateCompositorAndTransitionUpdate(
- const Element* animatingElement,
- Element& element,
- const ComputedStyle& style,
- ComputedStyle* parentStyle,
- CSSAnimationUpdate& animationUpdate) {
+void CSSAnimations::calculateUpdate(const Element* animatingElement,
+ Element& element,
+ const ComputedStyle& style,
+ ComputedStyle* parentStyle,
+ CSSAnimationUpdate& animationUpdate,
+ StyleResolver* resolver) {
calculateCompositorAnimationUpdate(animationUpdate, animatingElement, element,
style, parentStyle);
+ calculateAnimationUpdate(animationUpdate, animatingElement, element, style,
+ parentStyle, resolver);
+ calculateAnimationActiveInterpolations(animationUpdate, animatingElement);
calculateTransitionUpdate(animationUpdate, animatingElement, style);
+ calculateTransitionActiveInterpolations(animationUpdate, animatingElement);
}
static const KeyframeEffectModelBase* getKeyframeEffectModelBase(
@@ -423,7 +427,6 @@
*cssAnimations->m_runningAnimations[i]->animation);
}
}
- calculateAnimationActiveInterpolations(update, animatingElement);
}
void CSSAnimations::snapshotCompositorKeyframes(
@@ -823,7 +826,6 @@
}
}
}
- calculateTransitionActiveInterpolations(update, animatingElement);
}
void CSSAnimations::cancel() {
@@ -1092,18 +1094,6 @@
return toShadowRoot(treeScope.rootNode()).host() == element;
}
-bool CSSAnimations::isCustomPropertyHandle(const PropertyHandle& property) {
- return property.isCSSProperty() &&
- property.cssProperty() == CSSPropertyVariable;
-}
-
-bool CSSAnimations::isAnimatingCustomProperties(
- const ElementAnimations* elementAnimations) {
- return elementAnimations &&
- elementAnimations->effectStack().affectsProperties(
- isCustomPropertyHandle);
-}
-
DEFINE_TRACE(CSSAnimations) {
visitor->trace(m_transitions);
visitor->trace(m_pendingUpdate);

Powered by Google App Engine
This is Rietveld 408576698