Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 2521043003: Replace LayoutTests/paint/invalidation/text-selection-focus.html with a SimTest. (Closed)

Created:
4 years, 1 month ago by esprehn
Modified:
4 years, 1 month ago
Reviewers:
Rick Byers, pfeldman, ojan
CC:
blink-reviews, chromium-reviews, einbinder+watch-test-runner_chromium.org, jochen+watch_chromium.org, kinuko+watch, mlamouri+watch-test-runner_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace LayoutTests/paint/invalidation/text-selection-focus.html with a SimTest. This makes the test more clear, and removes the need for all of the plumbing for testRunner.animationScheduled which was only used by this one test. Committed: https://crrev.com/34afb5a8833154b2a52358f0a7e5ff873dd7050e Cr-Commit-Position: refs/heads/master@{#433738}

Patch Set 1 #

Patch Set 2 : copyrights. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+128 lines, -79 lines) Patch
M components/test_runner/test_runner.h View 4 chunks +0 lines, -9 lines 0 comments Download
M components/test_runner/test_runner.cc View 5 chunks +0 lines, -23 lines 0 comments Download
M components/test_runner/web_widget_test_client.cc View 2 chunks +0 lines, -5 lines 0 comments Download
D third_party/WebKit/LayoutTests/paint/invalidation/text-selection-focus.html View 1 chunk +0 lines, -31 lines 0 comments Download
D third_party/WebKit/LayoutTests/paint/invalidation/text-selection-focus-expected.txt View 1 chunk +0 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/editing/DOMSelection.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/BUILD.gn View 2 chunks +3 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/web/tests/TextSelectionRepaintTest.cpp View 1 1 chunk +51 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/web/tests/sim/SimPage.h View 1 chunk +30 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/web/tests/sim/SimPage.cpp View 1 1 chunk +28 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/tests/sim/SimTest.h View 4 chunks +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/tests/sim/SimTest.cpp View 3 chunks +10 lines, -0 lines 1 comment Download

Messages

Total messages: 19 (11 generated)
esprehn
4 years, 1 month ago (2016-11-22 00:09:17 UTC) #4
ojan
lgtm https://codereview.chromium.org/2521043003/diff/20001/third_party/WebKit/Source/web/tests/sim/SimTest.cpp File third_party/WebKit/Source/web/tests/sim/SimTest.cpp (right): https://codereview.chromium.org/2521043003/diff/20001/third_party/WebKit/Source/web/tests/sim/SimTest.cpp#newcode48 third_party/WebKit/Source/web/tests/sim/SimTest.cpp:48: LocalDOMWindow& SimTest::window() { This really makes me want ...
4 years, 1 month ago (2016-11-22 00:46:27 UTC) #5
esprehn
4 years, 1 month ago (2016-11-22 00:47:02 UTC) #7
ojan
I also wonder if it's worth putting in a README.md or something in test_runner to ...
4 years, 1 month ago (2016-11-22 00:47:24 UTC) #9
pfeldman
lgtm
4 years, 1 month ago (2016-11-22 01:45:16 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2521043003/20001
4 years, 1 month ago (2016-11-22 01:50:46 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-22 01:56:40 UTC) #17
commit-bot: I haz the power
4 years, 1 month ago (2016-11-22 02:08:12 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/34afb5a8833154b2a52358f0a7e5ff873dd7050e
Cr-Commit-Position: refs/heads/master@{#433738}

Powered by Google App Engine
This is Rietveld 408576698