Compositing Layer update for OffscreenCanvas resize

Compositing Layer update for OffscreenCanvas resize

After OffscreenCanvas resizes, OffscreenCanvasFrameDispatcher will pick up
the new size in the next commit() and prepares a compositor frame that is of
the new size. OffscreeCanvasCompositorFrameSink, the browser service-end of
FrameDispatcher, will re-create a new Surface upon detection of a different
size. Then it propagates the resizing information to OffscreenCanvasSurfaceImpl,
which then sends an IPC back to CanvasSurfaceLayerBridge to re-create a new
SurfaceLayer for HTMLCanvasElement on renderer/main.

This CL just creates the most basic functioning of OffscreenCanvas resize. It
does not consider the case when resizing happens after the last commit(). More
refactoring on OffscreenCanvasSurfaceImpl will be done to remove the sync IPC
in the future.

BUG=662498
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

[xlai (Olivia), 2016-11-22 15:50:53]

Description was changed from

==========
Compositing Layer update for OffscreenCanvas resize

After OffscreenCanvas resizes, OffscreenCanvasFrameDispatcher will pick up
the new size in the next commit() and prepares a compositor frame that is of
the new size. OffscreeCanvasCompositorFrameSink, the browser service-end of
FrameDispatcher, will re-create a new Surface upon detection of a different
size. Then it propagates the resizing information to OffscreenCanvasSurfaceImpl,
which then sends an IPC back to CanvasSurfaceLayerBridge to re-create a new
SurfaceLayer for HTMLCanvasElement on renderer/main.

This CL just creates the most basic functioning of OffscreenCanvas resize. It
does not consider the case when resizing happens after the last commit(). More
refactoring on OffscreenCanvasSurfaceImpl will be done to remove the sync IPC
in the future.

BUG=662498
==========

to

==========
Compositing Layer update for OffscreenCanvas resize

After OffscreenCanvas resizes, OffscreenCanvasFrameDispatcher will pick up
the new size in the next commit() and prepares a compositor frame that is of
the new size. OffscreeCanvasCompositorFrameSink, the browser service-end of
FrameDispatcher, will re-create a new Surface upon detection of a different
size. Then it propagates the resizing information to OffscreenCanvasSurfaceImpl,
which then sends an IPC back to CanvasSurfaceLayerBridge to re-create a new
SurfaceLayer for HTMLCanvasElement on renderer/main.

This CL just creates the most basic functioning of OffscreenCanvas resize. It
does not consider the case when resizing happens after the last commit(). More
refactoring on OffscreenCanvasSurfaceImpl will be done to remove the sync IPC
in the future.

BUG=662498
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
==========

[xlai (Olivia), 2016-11-22 15:56:12]

xlai@chromium.org changed reviewers:
+ fsamuel@chromium.org, xidachen@chromium.org

[xlai (Olivia), 2016-11-22 15:56:12]

fsamuel@: In this CL, I do the following:

1. add a return IPC from OffscreenCanvasSurfaceImpl (browser/UI) to
CanvasSurfaceLayerBridge (renderer/main) to trigger a replacement of
surfaceLayer
2. Let OffscreenCanvasCompositorFrameSink detect the size change upon receiving
a new compositor frame.

I did not do the following and plan to refactor it in the future (because they
conflict with my another ongoing CL):
1. Use a SolidColorLayer for canvas placeholder first and then replace with a
new SurfaceLayer 
2. Use Async IPC for GetSurfaceId
3. Implement OnSurfaceCreated in SurfaceObserver, in the future, the re-creation
of Surface in CompositorFrameSink will be moved to that function.

xidachen@: The current gpu test does not work yet (unless you drag the window a
bit) because I'm still waiting the style resizing CL to land.
Please take a look at the works in third_party/WebKit/. Thanks.

[Fady Samuel, 2016-11-22 16:04:10]

https://cs.chromium.org/chromium/src/services/ui/ws/gpu_compositor_frame_sink...

https://codereview.chromium.org/2521013003/diff/20001/content/browser/rendere...
File content/browser/renderer_host/offscreen_canvas_compositor_frame_sink.cc
(right):

https://codereview.chromium.org/2521013003/diff/20001/content/browser/rendere...
content/browser/renderer_host/offscreen_canvas_compositor_frame_sink.cc:53: if
(!GetSurfaceManager()->GetSurfaceForId(surface_id_)) {
I hate to be overly nitpicky but this flow doesn't match other
CompositorFrameSinks. In the interest of producing a unified API, please try to
get to that state.

SurfaceIdAllocator should be owned by CompositorFrameSink.

See GpuCompositorFrameSink::SubmitCompositorFrame. Please try to match that
code.

OffscreenCanvasCompositorFrameSink should not know about
OffscreenCanvasSurfaceImpl.