Cleanup: Remove for_search param from search::InstantExtendedEnabledParam()

Cleanup: Remove for_search param from search::InstantExtendedEnabledParam()

TBRing mechanical ios/ changes
TBR=noyau

BUG=627747
Committed: https://crrev.com/422b0e478e8913742d0692240eae016bad45f0a8
Cr-Commit-Position: refs/heads/master@{#434151}

[Marc Treib, 2016-11-22 15:22:54]

The CQ bit was checked by treib@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-22 15:23:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-22 15:32:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-22 15:32:54]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[Marc Treib, 2016-11-22 15:47:49]

The CQ bit was checked by treib@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-22 15:48:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-22 16:34:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-22 16:34:02]

Dry run: This issue passed the CQ dry run.

[Marc Treib, 2016-11-22 17:08:44]

treib@chromium.org changed reviewers:
+ pkasting@chromium.org

[Marc Treib, 2016-11-22 17:08:44]

One more episode in the neverending Instant series - PTAL!

[Peter Kasting, 2016-11-22 22:00:44]

LGTM

https://codereview.chromium.org/2520993004/diff/20001/components/search_engin...
File components/search_engines/template_url.cc (right):

https://codereview.chromium.org/2520993004/diff/20001/components/search_engin...
components/search_engines/template_url.cc:971: type_ == SEARCH
Nit: Add comment about why we want this to be the empty string when type_ ==
SEARCH

[Marc Treib, 2016-11-23 10:16:11]

Description was changed from

==========
Cleanup: Remove for_search param from search::InstantExtendedEnabledParam()

BUG=627747
==========

to

==========
Cleanup: Remove for_search param from search::InstantExtendedEnabledParam()

TBRing mechanical ios/ changes
TBR=noyau

BUG=627747
==========

[Marc Treib, 2016-11-23 10:29:19]

https://codereview.chromium.org/2520993004/diff/20001/components/search_engin...
File components/search_engines/template_url.cc (right):

https://codereview.chromium.org/2520993004/diff/20001/components/search_engin...
components/search_engines/template_url.cc:971: type_ == SEARCH
On 2016/11/22 22:00:44, Peter Kasting wrote:
> Nit: Add comment about why we want this to be the empty string when type_ ==
> SEARCH

Done.

[Marc Treib, 2016-11-23 10:29:25]

The CQ bit was checked by treib@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-23 10:29:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-23 11:27:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-23 11:27:16]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Marc Treib, 2016-11-23 12:04:31]

The CQ bit was checked by treib@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-23 12:04:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-23 12:35:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-23 12:35:37]

Dry run: This issue passed the CQ dry run.

[Marc Treib, 2016-11-23 12:42:45]

The CQ bit was checked by treib@chromium.org

[Marc Treib, 2016-11-23 12:42:45]

The patchset sent to the CQ was uploaded after l-g-t-m from
pkasting@chromium.org
Link to the patchset: https://codereview.chromium.org/2520993004/#ps40001
(title: "comment")

[commit-bot: I haz the power, 2016-11-23 12:42:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-23 12:46:43]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1479904965459170,
"parent_rev": "657b522f3f98798d09478c64ac67e63f8d4b8308", "commit_rev":
"d2ce37e34aae55fcc961d4aa0f4873b801d07dca"}

[commit-bot: I haz the power, 2016-11-23 12:47:08]

Description was changed from

==========
Cleanup: Remove for_search param from search::InstantExtendedEnabledParam()

TBRing mechanical ios/ changes
TBR=noyau

BUG=627747
==========

to

==========
Cleanup: Remove for_search param from search::InstantExtendedEnabledParam()

TBRing mechanical ios/ changes
TBR=noyau

BUG=627747
==========

[commit-bot: I haz the power, 2016-11-23 12:47:09]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-11-23 12:49:28]

Description was changed from

==========
Cleanup: Remove for_search param from search::InstantExtendedEnabledParam()

TBRing mechanical ios/ changes
TBR=noyau

BUG=627747
==========

to

==========
Cleanup: Remove for_search param from search::InstantExtendedEnabledParam()

TBRing mechanical ios/ changes
TBR=noyau

BUG=627747

Committed: https://crrev.com/422b0e478e8913742d0692240eae016bad45f0a8
Cr-Commit-Position: refs/heads/master@{#434151}
==========

[commit-bot: I haz the power, 2016-11-23 12:49:29]

Patchset 3 (id:??) landed as
https://crrev.com/422b0e478e8913742d0692240eae016bad45f0a8
Cr-Commit-Position: refs/heads/master@{#434151}