Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issue 2520993004: Cleanup: Remove for_search param from search::InstantExtendedEnabledParam() (Closed)

Created:
4 years, 1 month ago by Marc Treib
Modified:
4 years ago
Reviewers:
Peter Kasting
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cleanup: Remove for_search param from search::InstantExtendedEnabledParam() TBRing mechanical ios/ changes TBR=noyau BUG=627747 Committed: https://crrev.com/422b0e478e8913742d0692240eae016bad45f0a8 Cr-Commit-Position: refs/heads/master@{#434151}

Patch Set 1 #

Patch Set 2 : fix #

Total comments: 2

Patch Set 3 : comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -40 lines) Patch
M chrome/browser/search_engines/ui_thread_search_terms_data.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/search_engines/ui_thread_search_terms_data.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M components/omnibox/browser/history_url_provider.cc View 4 chunks +4 lines, -9 lines 0 comments Download
M components/search/search.h View 1 2 1 chunk +1 line, -5 lines 0 comments Download
M components/search/search.cc View 1 2 1 chunk +1 line, -4 lines 0 comments Download
M components/search/search_unittest.cc View 1 chunk +2 lines, -6 lines 0 comments Download
M components/search_engines/search_terms_data.h View 1 chunk +3 lines, -2 lines 0 comments Download
M components/search_engines/search_terms_data.cc View 1 chunk +1 line, -2 lines 0 comments Download
M components/search_engines/template_url.cc View 1 2 1 chunk +6 lines, -4 lines 0 comments Download
M ios/chrome/browser/search_engines/ui_thread_search_terms_data.h View 1 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/search_engines/ui_thread_search_terms_data.cc View 1 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 29 (23 generated)
Marc Treib
One more episode in the neverending Instant series - PTAL!
4 years, 1 month ago (2016-11-22 17:08:44 UTC) #10
Peter Kasting
LGTM https://codereview.chromium.org/2520993004/diff/20001/components/search_engines/template_url.cc File components/search_engines/template_url.cc (right): https://codereview.chromium.org/2520993004/diff/20001/components/search_engines/template_url.cc#newcode971 components/search_engines/template_url.cc:971: type_ == SEARCH Nit: Add comment about why ...
4 years, 1 month ago (2016-11-22 22:00:44 UTC) #11
Marc Treib
https://codereview.chromium.org/2520993004/diff/20001/components/search_engines/template_url.cc File components/search_engines/template_url.cc (right): https://codereview.chromium.org/2520993004/diff/20001/components/search_engines/template_url.cc#newcode971 components/search_engines/template_url.cc:971: type_ == SEARCH On 2016/11/22 22:00:44, Peter Kasting wrote: ...
4 years, 1 month ago (2016-11-23 10:29:19 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2520993004/40001
4 years ago (2016-11-23 12:42:57 UTC) #24
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years ago (2016-11-23 12:47:09 UTC) #27
commit-bot: I haz the power
4 years ago (2016-11-23 12:49:29 UTC) #29
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/422b0e478e8913742d0692240eae016bad45f0a8
Cr-Commit-Position: refs/heads/master@{#434151}

Powered by Google App Engine
This is Rietveld 408576698