Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Unified Diff: components/search/search_unittest.cc

Issue 2520993004: Cleanup: Remove for_search param from search::InstantExtendedEnabledParam() (Closed)
Patch Set: comment Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/search/search.cc ('k') | components/search_engines/search_terms_data.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/search/search_unittest.cc
diff --git a/components/search/search_unittest.cc b/components/search/search_unittest.cc
index d5adaa47b148311577e3dc55391ca48ae2a9362a..07db3fb8f423f60d7aca8b49df03c1f0b512cc40 100644
--- a/components/search/search_unittest.cc
+++ b/components/search/search_unittest.cc
@@ -165,17 +165,13 @@ typedef EmbeddedSearchFieldTrialTest InstantExtendedEnabledParamTest;
TEST_F(InstantExtendedEnabledParamTest, QueryExtractionDisabled) {
ASSERT_TRUE(base::FieldTrialList::CreateFieldTrial("EmbeddedSearch",
"Group1 espv:12"));
- // Make sure InstantExtendedEnabledParam() returns an empty string for search
- // requests.
- EXPECT_EQ("", InstantExtendedEnabledParam(true));
- EXPECT_EQ("espv=12&", InstantExtendedEnabledParam(false));
+ EXPECT_EQ("espv=12&", InstantExtendedEnabledParam());
}
TEST_F(InstantExtendedEnabledParamTest, UseDefaultEmbeddedSearchPageVersion) {
ASSERT_TRUE(base::FieldTrialList::CreateFieldTrial(
"EmbeddedSearch", "Group1 espv:-1"));
- EXPECT_EQ("", InstantExtendedEnabledParam(true));
- EXPECT_EQ("espv=2&", InstantExtendedEnabledParam(false));
+ EXPECT_EQ("espv=2&", InstantExtendedEnabledParam());
}
#endif // !defined(OS_IOS) && !defined(OS_ANDROID)
« no previous file with comments | « components/search/search.cc ('k') | components/search_engines/search_terms_data.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698