Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 2520913002: [runtime] Rename {JSGeneratorObject::operand_stack} field. (Closed)

Created:
4 years, 1 month ago by Michael Starzinger
Modified:
4 years, 1 month ago
Reviewers:
neis
CC:
v8-reviews_googlegroups.com, rmcilroy
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[runtime] Rename {JSGeneratorObject::operand_stack} field. This renames the {operand_stack} field to {register_file}, to refelct how said field is used on all {JSGeneratorObject} instances by now. This is a pure refactoring CL, not changes in semantics. R=neis@chromium.org Committed: https://crrev.com/71c5904fb7e58af39dc33240cfb3720555bb4c03 Cr-Commit-Position: refs/heads/master@{#41140}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -16 lines) Patch
M src/compiler/access-builder.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/compiler/access-builder.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/compiler/js-typed-lowering.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/interpreter/interpreter.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/objects.h View 2 chunks +4 lines, -4 lines 0 comments Download
M src/objects-debug.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/objects-inl.h View 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/runtime-generator.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 15 (10 generated)
Michael Starzinger
4 years, 1 month ago (2016-11-21 12:45:58 UTC) #4
neis
lgtm, thanks
4 years, 1 month ago (2016-11-21 13:03:37 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2520913002/1
4 years, 1 month ago (2016-11-21 13:29:15 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-21 13:31:13 UTC) #13
commit-bot: I haz the power
4 years, 1 month ago (2016-11-21 13:31:44 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/71c5904fb7e58af39dc33240cfb3720555bb4c03
Cr-Commit-Position: refs/heads/master@{#41140}

Powered by Google App Engine
This is Rietveld 408576698