 Chromium Code Reviews
 Chromium Code Reviews Issue 2520873002:
  [css-ui] Add support for caret-color property  (Closed)
    
  
    Issue 2520873002:
  [css-ui] Add support for caret-color property  (Closed) 
  | Index: third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp | 
| diff --git a/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp b/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp | 
| index 0c8ab2472cb5acb14d08a98fa94207d8f447c4ba..5aa42be0467eff3085e08968dc3e1c6ca6ab3651 100644 | 
| --- a/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp | 
| +++ b/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp | 
| @@ -2205,6 +2205,13 @@ const CSSValue* ComputedStyleCSSValueMapping::get( | 
| return valueForShadowList(style.boxShadow(), style, true); | 
| case CSSPropertyCaptionSide: | 
| return CSSIdentifierValue::create(style.captionSide()); | 
| + case CSSPropertyCaretColor: | 
| + if (style.caretColor().isCurrentColor()) | 
| + return CSSIdentifierValue::create(CSSValueCurrentcolor); | 
| + if (style.caretColor().isAutoColor()) | 
| + return CSSIdentifierValue::create(CSSValueAuto); | 
| + return CSSColorValue::create( | 
| + style.caretColor().resolve(style.color()).rgb()); | 
| 
Timothy Loh
2016/11/28 03:11:21
This line is weird, resolve() is to handle current
 
Manuel Rego
2016/11/28 10:47:55
Sure, I didn't realize before but it seems we don'
 | 
| case CSSPropertyClear: | 
| return CSSIdentifierValue::create(style.clear()); | 
| case CSSPropertyColor: |