[css-ui] Add support for caret-color property

third_party/WebKit/Source/core/animation/css/CSSAnimatableValueFactory.cpp

Index: third_party/WebKit/Source/core/animation/css/CSSAnimatableValueFactory.cpp
diff --git a/third_party/WebKit/Source/core/animation/css/CSSAnimatableValueFactory.cpp b/third_party/WebKit/Source/core/animation/css/CSSAnimatableValueFactory.cpp
index 6641d8abc3643b2a574912dfe67815257a195630..e4120578272119ace96de6983032fdb4be39c5d5 100644
--- a/third_party/WebKit/Source/core/animation/css/CSSAnimatableValueFactory.cpp
+++ b/third_party/WebKit/Source/core/animation/css/CSSAnimatableValueFactory.cpp
@@ -407,6 +407,8 @@ PassRefPtr<AnimatableValue> CSSAnimatableValueFactory::create(
             CSSIdentifierValue::create(CSSValueAuto));
       }
       return createFromLengthBox(style.clip(), style);
+    case CSSPropertyCaretColor:
+      return createFromColor(property, style);

[Timothy Loh, 2016/11/28 03:11:21]

I'm not sure if this is going to end up doing the right thing for auto. Since
the computed value for auto is auto, we (I think) shouldn't transition between
auto and specified colors. From what I can tell, this code will end up doing
that? I would suggest implementing transition and animation logic for
caret-color in a separate patch.

[Manuel Rego, 2016/11/28 10:47:55]

Mmmm, interesting I didn't realize about that.
I'm fine with moving this to a follow-up patch.

The problem with caret-color is that both "auto" and "currentColor"
have as computed value "auto" and "currentColor".
So I'm not sure if we could do a transition/animation from
"currentColor" to "red" or from "auto" to "red".
However, the rest of color properties allow a transition from
"currentColor" to "red" (because the computed value is never
"currentColor").
I'm not sure what should we do here, maybe @florian can help
to resolve this doubt from the specs point of view.

     case CSSPropertyColor:
       return createFromColor(property, style);
     case CSSPropertyFillOpacity: