[css-ui] Add support for caret-color property

third_party/WebKit/Source/core/animation/css/CSSAnimatableValueFactory.cpp

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 389 matching lines @@
     case CSSPropertyBottom:
       return createFromLength(style.bottom(), style);
     case CSSPropertyBoxShadow:
       return AnimatableShadow::create(style.boxShadow(), style.color());
     case CSSPropertyClip:
       if (style.hasAutoClip()) {
         return AnimatableUnknown::create(
             CSSIdentifierValue::create(CSSValueAuto));
       }
       return createFromLengthBox(style.clip(), style);
+    case CSSPropertyCaretColor:
+      return createFromColor(property, style);

[Timothy Loh, 2016/11/28 03:11:21]

I'm not sure if this is going to end up doing the right thing for auto. Since
the computed value for auto is auto, we (I think) shouldn't transition between
auto and specified colors. From what I can tell, this code will end up doing
that? I would suggest implementing transition and animation logic for
caret-color in a separate patch.

[Manuel Rego, 2016/11/28 10:47:55]

Mmmm, interesting I didn't realize about that.
I'm fine with moving this to a follow-up patch.

The problem with caret-color is that both "auto" and "currentColor"
have as computed value "auto" and "currentColor".
So I'm not sure if we could do a transition/animation from
"currentColor" to "red" or from "auto" to "red".
However, the rest of color properties allow a transition from
"currentColor" to "red" (because the computed value is never
"currentColor").
I'm not sure what should we do here, maybe @florian can help
to resolve this doubt from the specs point of view.

     case CSSPropertyColor:
       return createFromColor(property, style);
     case CSSPropertyFillOpacity:
       return createFromDouble(style.fillOpacity());
     case CSSPropertyFill:
       return AnimatableSVGPaint::create(
           normalizeSVGPaintType(style.svgStyle().fillPaintType()),
           normalizeSVGPaintType(style.svgStyle().visitedLinkFillPaintType()),
           style.svgStyle().fillPaintColor(),
           style.svgStyle().visitedLinkFillPaintColor(),
@@ skipping 249 matching lines @@
       if (style.hasAutoZIndex())
         return AnimatableUnknown::create(CSSValueAuto);
       return createFromDouble(style.zIndex());
     default:
       NOTREACHED();
       return nullptr;
   }
 }
 
 }  // namespace blink