Make HarfBuzzShaperTest.ResolveCandidateRunsUnicodeVariants more robust

Make HarfBuzzShaperTest.ResolveCandidateRunsUnicodeVariants more robust

Some unknown changes to Linux bots figured out that this test is not as
robust as it should be, by relying non-mandatory recommendation.

Since it has started failing on Linux bots, it was disabled in [1].
This patch makes it more robust to fonts that do not follow the
OpenType recommendations and re-enable it.

[1] https://codereview.chromium.org/2516273002

BUG=667147
Committed: https://crrev.com/c3d0368b185088d697bad36d0928a7409d1c970a
Cr-Commit-Position: refs/heads/master@{#433874}

[kojii, 2016-11-21 07:17:09]

The CQ bit was checked by kojii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-21 07:17:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kojii, 2016-11-21 07:32:10]

Description was changed from

==========
hbtest

BUG=
==========

to

==========
Make HarfBuzzShaperTest.ResolveCandidateRunsUnicodeVariants more robust

Some unknown changes to Linux bots figured out that this test is not as
robust as it should be, by relying non-mandatory recommendation.

Since it has started failing on Linux ASAN/LSAN bots, it was disabled
in [1]. This patch makes it more robust and re-enable.

[1] https://codereview.chromium.org/2516273002

BUG=667147
==========

[kojii, 2016-11-21 07:36:15]

Description was changed from

==========
Make HarfBuzzShaperTest.ResolveCandidateRunsUnicodeVariants more robust

Some unknown changes to Linux bots figured out that this test is not as
robust as it should be, by relying non-mandatory recommendation.

Since it has started failing on Linux ASAN/LSAN bots, it was disabled
in [1]. This patch makes it more robust and re-enable.

[1] https://codereview.chromium.org/2516273002

BUG=667147
==========

to

==========
Make HarfBuzzShaperTest.ResolveCandidateRunsUnicodeVariants more robust

Some unknown changes to Linux bots figured out that this test is not as
robust as it should be, by relying non-mandatory recommendation.

Since it has started failing on Linux bots, it was disabled in [1].
This patch makes it more robust to fonts that do not follow the
OpenType recommendations and re-enable it.

[1] https://codereview.chromium.org/2516273002

BUG=667147
==========

[commit-bot: I haz the power, 2016-11-21 11:18:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-21 11:18:16]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[kojii, 2016-11-22 02:49:34]

kojii@chromium.org changed reviewers:
+ drott@chromium.org, eae@chromium.org

[kojii, 2016-11-22 02:49:35]

PTAL.

[drott, 2016-11-22 07:20:40]

LGTM, thanks for re-enabling this.

[kojii, 2016-11-22 07:54:01]

The CQ bit was checked by kojii@chromium.org

[commit-bot: I haz the power, 2016-11-22 07:54:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-22 11:14:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-22 11:14:28]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[kojii, 2016-11-22 13:57:25]

The CQ bit was checked by kojii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-22 13:57:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-22 15:44:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-22 15:44:17]

Dry run: This issue passed the CQ dry run.

[kojii, 2016-11-22 15:47:32]

The CQ bit was checked by kojii@chromium.org

[kojii, 2016-11-22 15:47:32]

The patchset sent to the CQ was uploaded after l-g-t-m from drott@chromium.org
Link to the patchset: https://codereview.chromium.org/2520833002/#ps20001
(title: "Mac still needs to be excepted")

[commit-bot: I haz the power, 2016-11-22 15:47:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-22 15:54:29]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1479829652102560,
"parent_rev": "417116a9cd1cfd77412e24e8e2b93b7f0977df94", "commit_rev":
"8aa5edc3c34fee986d60794c8aa47a44c380b35e"}

[commit-bot: I haz the power, 2016-11-22 15:54:54]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-22 15:58:08]

Description was changed from

==========
Make HarfBuzzShaperTest.ResolveCandidateRunsUnicodeVariants more robust

Some unknown changes to Linux bots figured out that this test is not as
robust as it should be, by relying non-mandatory recommendation.

Since it has started failing on Linux bots, it was disabled in [1].
This patch makes it more robust to fonts that do not follow the
OpenType recommendations and re-enable it.

[1] https://codereview.chromium.org/2516273002

BUG=667147
==========

to

==========
Make HarfBuzzShaperTest.ResolveCandidateRunsUnicodeVariants more robust

Some unknown changes to Linux bots figured out that this test is not as
robust as it should be, by relying non-mandatory recommendation.

Since it has started failing on Linux bots, it was disabled in [1].
This patch makes it more robust to fonts that do not follow the
OpenType recommendations and re-enable it.

[1] https://codereview.chromium.org/2516273002

BUG=667147

Committed: https://crrev.com/c3d0368b185088d697bad36d0928a7409d1c970a
Cr-Commit-Position: refs/heads/master@{#433874}
==========

[commit-bot: I haz the power, 2016-11-22 15:58:10]

Patchset 2 (id:??) landed as
https://crrev.com/c3d0368b185088d697bad36d0928a7409d1c970a
Cr-Commit-Position: refs/heads/master@{#433874}

[Matt Giuca, 2016-11-23 00:24:49]

mgiuca@chromium.org changed reviewers:
+ mgiuca@chromium.org

[Matt Giuca, 2016-11-23 00:24:49]

Thanks for following up on this!