Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(667)

Unified Diff: third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaperTest.cpp

Issue 2520833002: Make HarfBuzzShaperTest.ResolveCandidateRunsUnicodeVariants more robust (Closed)
Patch Set: Mac still needs to be excepted Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/platform/fonts/shaping/ShapeResultTestInfo.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaperTest.cpp
diff --git a/third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaperTest.cpp b/third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaperTest.cpp
index 3b5b343914faffc7f757b5b400c0b62730a29506..514e8e42fcf5ffc84da4ca9a3e9b991611588a1f 100644
--- a/third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaperTest.cpp
+++ b/third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaperTest.cpp
@@ -89,12 +89,10 @@ TEST_F(HarfBuzzShaperTest, ResolveCandidateRunsUnicodeVariants) {
// If the specified VS is not in the font, it's mapped to .notdef.
// then hb_ot_hide_default_ignorables() swaps it to a space with zero-advance.
// http://lists.freedesktop.org/archives/harfbuzz/2015-May/004888.html
-// OpenType recommends Glyph ID 3 for a space; not a hard requirement though.
-// https://www.microsoft.com/typography/otspec/recom.htm
#if !OS(MACOSX)
-// TODO(mgiuca): This expectation has been DISABLED due to failing on
-// Linux bots. See https://crbug.com/667147.
-// EXPECT_EQ(3u, testInfo(result)->glyphForTesting(0, 1)) << test.name;
+ EXPECT_EQ(testInfo(result)->fontDataForTesting(0)->spaceGlyph(),
+ testInfo(result)->glyphForTesting(0, 1))
+ << test.name;
#endif
EXPECT_EQ(0.f, testInfo(result)->advanceForTesting(0, 1)) << test.name;
} else {
« no previous file with comments | « no previous file | third_party/WebKit/Source/platform/fonts/shaping/ShapeResultTestInfo.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698