Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 2520803002: Calling clearSelection instead of unselect (Closed)

Created:
4 years, 1 month ago by Jinsuk Kim
Modified:
4 years, 1 month ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

Calling clearSelection instead of unselect crrev.com/2407303005 introduced a bug by having |onDestroyActionMode| call |mWebContents.unselect()| instead of |clearSelection()|. This CL fixes that. BUG=666979 TBR=aelias@chromium.org Review-Url: https://codereview.chromium.org/2513203002 Cr-Commit-Position: refs/heads/master@{#433427} (cherry picked from commit 4ff3e57600d5433dd8d31c5dcdf7d0e26de73f02) NOTRY=true NOPRESUBMIT=true

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/public/android/java/src/org/chromium/content/browser/SelectionPopupController.java View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (7 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2520803002/1
4 years, 1 month ago (2016-11-21 04:22:59 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 1 month ago (2016-11-21 04:23:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2520803002/1
4 years, 1 month ago (2016-11-21 04:24:46 UTC) #8
commit-bot: I haz the power
4 years, 1 month ago (2016-11-21 04:27:49 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698