Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 2513203002: Calling clearSelection instead of unselect (Closed)

Created:
4 years, 1 month ago by amaralp
Modified:
4 years, 1 month ago
CC:
agrieve+watch_chromium.org, chromium-reviews, darin-cc_chromium.org, jam
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Calling clearSelection instead of unselect crrev.com/2407303005 introduced a bug by having |onDestroyActionMode| call |mWebContents.unselect()| instead of |clearSelection()|. This CL fixes that. BUG=666979 Committed: https://crrev.com/4ff3e57600d5433dd8d31c5dcdf7d0e26de73f02 Cr-Commit-Position: refs/heads/master@{#433427}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/public/android/java/src/org/chromium/content/browser/SelectionPopupController.java View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (8 generated)
amaralp
PTAL
4 years, 1 month ago (2016-11-19 02:11:33 UTC) #4
aelias_OOO_until_Jul13
lgtm
4 years, 1 month ago (2016-11-19 02:30:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2513203002/1
4 years, 1 month ago (2016-11-19 18:50:33 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-19 18:56:23 UTC) #11
commit-bot: I haz the power
4 years, 1 month ago (2016-11-19 18:58:24 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4ff3e57600d5433dd8d31c5dcdf7d0e26de73f02
Cr-Commit-Position: refs/heads/master@{#433427}

Powered by Google App Engine
This is Rietveld 408576698