chrome/browser/resources/settings/on_startup_page/startup_url_entry.html - Issue 2520573002: MD Settings: implement support for extension-controlled startup URLs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/on_startup_page/startup_url_entry.html

Issue 2520573002: MD Settings: implement support for extension-controlled startup URLs (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/settings/on_startup_page/on_startup_page.html ('K') | « chrome/browser/resources/settings/on_startup_page/on_startup_page.html ('k') | chrome/browser/resources/settings/on_startup_page/startup_url_entry.js » ('j') | chrome/browser/resources/settings/on_startup_page/startup_urls_page.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/on_startup_page/startup_url_entry.html

diff --git a/chrome/browser/resources/settings/on_startup_page/startup_url_entry.html b/chrome/browser/resources/settings/on_startup_page/startup_url_entry.html

index 724cd4ce8945f7afe94245e372a2ca670752d228..25ed073097b6dd51d6b40984742a0eb0d88d560b 100644

--- a/chrome/browser/resources/settings/on_startup_page/startup_url_entry.html

+++ b/chrome/browser/resources/settings/on_startup_page/startup_url_entry.html

@@ -22,19 +22,21 @@

<div class="text-elide">[[model.title]]</div>

<div class="text-elide secondary">[[model.url]]</div>

</div>

- <paper-icon-button id="dots" icon="cr:more-vert" tabindex$="[[tabindex]]"

- on-tap="onDotsTap_">

- </paper-icon-button>

- <template is="cr-lazy-render" id="menu">

- <dialog is="cr-action-menu">

- <button class="dropdown-item" role="option" on-tap="onEditTap_">

- $i18n{onStartupEdit}

- </button>

- <button class="dropdown-item" role="option" id="remove"

- on-tap="onRemoveTap_">

- $i18n{onStartupRemove}

- </button>

- </dialog>

+ <template is="dom-if" if="[[editable]]">

dpapad 2016/11/18 23:46:28 Can you add a test checking that a non editable en

Dan Beam 2016/11/18 23:51:04 yes (this is exactly the thing I planned on testin

+ <paper-icon-button id="dots" icon="cr:more-vert"

+ tabindex$="[[tabindex]]" on-tap="onDotsTap_">

+ </paper-icon-button>

+ <template is="cr-lazy-render" id="menu">

+ <dialog is="cr-action-menu">

+ <button class="dropdown-item" role="option" on-tap="onEditTap_">

+ $i18n{onStartupEdit}

+ </button>

+ <button class="dropdown-item" role="option" id="remove"

+ on-tap="onRemoveTap_">

+ $i18n{onStartupRemove}

+ </button>

+ </dialog>

+ </template>

</template>

</div>

</template>