chrome/browser/resources/settings/on_startup_page/on_startup_page.html - Issue 2520573002: MD Settings: implement support for extension-controlled startup URLs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/on_startup_page/on_startup_page.html

Issue 2520573002: MD Settings: implement support for extension-controlled startup URLs (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/settings/controls/controlled_radio_button.js ('K') | « chrome/browser/resources/settings/controls/controlled_radio_button.js ('k') | chrome/browser/resources/settings/on_startup_page/startup_url_entry.html » ('j') | chrome/browser/resources/settings/on_startup_page/startup_url_entry.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/on_startup_page/on_startup_page.html

diff --git a/chrome/browser/resources/settings/on_startup_page/on_startup_page.html b/chrome/browser/resources/settings/on_startup_page/on_startup_page.html

index 1145e0706ab2fde26e5e6b9b1e83add027d3245f..b679c1625b849c4781d91244a0d635bc9efa168c 100644

--- a/chrome/browser/resources/settings/on_startup_page/on_startup_page.html

+++ b/chrome/browser/resources/settings/on_startup_page/on_startup_page.html

@@ -38,7 +38,8 @@

</div>

<template is="dom-if"

if="[[showStartupUrls_(prefs.session.restore_on_startup.value)]]">

- <settings-startup-urls-page></settings-startup-urls-page>

+ <settings-startup-urls-page prefs="[[prefs]]">

dpapad 2016/11/18 23:46:28 In almost all cases where we pass |prefs| we use t

Dan Beam 2016/11/18 23:51:04 i don't set prefs.* in the startup pages. that's

+ </settings-startup-urls-page>

</template>