Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1103)

Unified Diff: xfa/fxfa/app/xfa_ffapp_unittest.cpp

Issue 2520493002: Make CPDF_Stream() take unique_ptr's to its dictionary. (Closed)
Patch Set: rebase, lint, fix new test. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « fpdfsdk/fpdfsave.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: xfa/fxfa/app/xfa_ffapp_unittest.cpp
diff --git a/xfa/fxfa/app/xfa_ffapp_unittest.cpp b/xfa/fxfa/app/xfa_ffapp_unittest.cpp
index 10c0545fbbd55d7c03457dd96ea252ef6df1f811..b35780d218e40b4a549e3ca2ab90dcce257c0858 100644
--- a/xfa/fxfa/app/xfa_ffapp_unittest.cpp
+++ b/xfa/fxfa/app/xfa_ffapp_unittest.cpp
@@ -46,11 +46,11 @@ TEST(CXFAFileRead, NormalStreams) {
// 16 chars total.
stream1->InitStream(reinterpret_cast<const uint8_t*>("one t"), 5,
- new CPDF_Dictionary());
+ pdfium::MakeUnique<CPDF_Dictionary>());
stream2->InitStream(reinterpret_cast<const uint8_t*>("wo "), 3,
- new CPDF_Dictionary());
+ pdfium::MakeUnique<CPDF_Dictionary>());
stream3->InitStream(reinterpret_cast<const uint8_t*>("three!!!"), 8,
- new CPDF_Dictionary());
+ pdfium::MakeUnique<CPDF_Dictionary>());
streams.push_back(stream1.get());
streams.push_back(stream2.get());
« no previous file with comments | « fpdfsdk/fpdfsave.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698