Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(576)

Unified Diff: content/common/frame_replication_state.h

Issue 2520223002: Replicate a parsed feature policy representation so it doesn't need to be parsed in the browser pro… (Closed)
Patch Set: Replicate a parsed feature policy representation so it doesn't need to be parsed in the browser pro… Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/common/frame_replication_state.h
diff --git a/content/common/frame_replication_state.h b/content/common/frame_replication_state.h
index cc8d4780d30615511950eba6ba1b31482c13bbea..8fcae1ca3e93f7b484463d536792dc631a87cac7 100644
--- a/content/common/frame_replication_state.h
+++ b/content/common/frame_replication_state.h
@@ -20,6 +20,19 @@ enum class WebSandboxFlags;
namespace content {
+// This struct holds feature policy whitelist data that needs to be replicated
+// between a RenderFrame and any of its associated RenderFrameProxies. It forms
+// part of the FrameReplicationState below.
alexmos 2016/12/01 02:04:19 nit: Maybe also mention that this is a whitelist f
raymes 2016/12/01 03:03:09 Done.
+struct CONTENT_EXPORT FeaturePolicyParsedWhitelist {
+ FeaturePolicyParsedWhitelist();
+ FeaturePolicyParsedWhitelist(const FeaturePolicyParsedWhitelist& fppw);
+ ~FeaturePolicyParsedWhitelist();
+
+ std::string feature_name;
+ bool matches_all_origins;
+ std::vector<url::Origin> origins;
+};
+
// This structure holds information that needs to be replicated between a
// RenderFrame and any of its associated RenderFrameProxies.
struct CONTENT_EXPORT FrameReplicationState {
@@ -84,9 +97,9 @@ struct CONTENT_EXPORT FrameReplicationState {
// scratch.
std::string unique_name;
- // Feature policy header. May be empty if no header was sent with the
+ // Parsed feature policy header. May be empty if no header was sent with the
// document.
- std::string feature_policy_header;
+ std::vector<FeaturePolicyParsedWhitelist> feature_policy_header;
alexmos 2016/12/01 02:04:19 Do we need to keep calling this feature_policy_hea
raymes 2016/12/01 03:03:09 Exactly - this is to distinguish it from the attri
// Accumulated CSP headers - gathered from http headers, <meta> elements,
// parent frames (in case of about:blank frames).

Powered by Google App Engine
This is Rietveld 408576698