Replicate a parsed feature policy representation so it doesn't need to be parsed in the browser pro…

content/common/frame_replication_state.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_COMMON_FRAME_REPLICATION_STATE_H_
 #define CONTENT_COMMON_FRAME_REPLICATION_STATE_H_
 
 #include <string>
 #include <vector>
 
 #include "content/common/content_export.h"
 #include "content/common/content_security_policy_header.h"
 #include "third_party/WebKit/public/platform/WebInsecureRequestPolicy.h"
 #include "url/origin.h"
 
 namespace blink {
 enum class WebTreeScopeType;
 enum class WebSandboxFlags;
 }
 
 namespace content {
 
+// This struct holds feature policy whitelist data that needs to be replicated
+// between a RenderFrame and any of its associated RenderFrameProxies. It forms
+// part of the FrameReplicationState below.

[alexmos, 2016/12/01 02:04:19]

nit: Maybe also mention that this is a whitelist for one feature, and the full
feature policy is a list of these.

[raymes, 2016/12/01 03:03:09]

Done.

+struct CONTENT_EXPORT FeaturePolicyParsedWhitelist {
+  FeaturePolicyParsedWhitelist();
+  FeaturePolicyParsedWhitelist(const FeaturePolicyParsedWhitelist& fppw);
+  ~FeaturePolicyParsedWhitelist();
+
+  std::string feature_name;
+  bool matches_all_origins;
+  std::vector<url::Origin> origins;
+};
+
 // This structure holds information that needs to be replicated between a
 // RenderFrame and any of its associated RenderFrameProxies.
 struct CONTENT_EXPORT FrameReplicationState {
   FrameReplicationState();
   FrameReplicationState(blink::WebTreeScopeType scope,
                         const std::string& name,
                         const std::string& unique_name,
                         blink::WebSandboxFlags sandbox_flags,
                         blink::WebInsecureRequestPolicy insecure_request_policy,
                         bool has_potentially_trustworthy_unique_origin);
@@ skipping 44 matching lines @@
   // across different, unrelated navigations (i.e. to refer to the frame
   // when going back/forward in session history OR when refering to the frame
   // in layout tests results).
   //
   // |unique_name| needs to be replicated to ensure that unique name for a given
   // frame is the same across all renderers - without replication a renderer
   // might arrive at a different value when recalculating the unique name from
   // scratch.
   std::string unique_name;
 
-  // Feature policy header. May be empty if no header was sent with the
+  // Parsed feature policy header. May be empty if no header was sent with the
   // document.
-  std::string feature_policy_header;
+  std::vector<FeaturePolicyParsedWhitelist> feature_policy_header;

[alexmos, 2016/12/01 02:04:19]

Do we need to keep calling this feature_policy_header and not just
feature_policy?  Presumably yes, since a frame's feature policy might also
depend on <iframe> enable/disable attributes?

[raymes, 2016/12/01 03:03:09]

Exactly - this is to distinguish it from the attribute that we plan to add.

 
   // Accumulated CSP headers - gathered from http headers, <meta> elements,
   // parent frames (in case of about:blank frames).
   std::vector<ContentSecurityPolicyHeader> accumulated_csp_headers;
 
   // Whether the frame is in a document tree or a shadow tree, per the Shadow
   // DOM spec: https://w3c.github.io/webcomponents/spec/shadow/
   // Note: This should really be const, as it can never change once a frame is
   // created. However, making it const makes it a pain to embed into IPC message
   // params: having a const member implicitly deletes the copy assignment
   // operator.
   blink::WebTreeScopeType scope;
 
   // The insecure request policy that a frame's current document is enforcing.
   // Updates are immediately sent to all frame proxies when frames live in
   // different processes.
   blink::WebInsecureRequestPolicy insecure_request_policy;
 
   // True if a frame's origin is unique and should be considered potentially
   // trustworthy.
   bool has_potentially_trustworthy_unique_origin;
 
   // TODO(alexmos): Eventually, this structure can also hold other state that
   // needs to be replicated, such as frame sizing info.
 };
 
 }  // namespace content
 
 #endif  // CONTENT_COMMON_FRAME_REPLICATION_STATE_H_