Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issue 2520143002: Move touchscreen_util.cc/h from ash to ui. (Closed)

Created:
4 years, 1 month ago by kylechar
Modified:
4 years ago
Reviewers:
oshima, sadrul
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move touchscreen_util.cc/h from ash to ui. AssociatedTouchscreens() is used by DisplayChangeObserver/DisplayManager and needed for mustash. Remove the minimal ash dependencies in the tests, they weren't actually needed, and move the tests too. BUG=667344 Committed: https://crrev.com/3ce955f57b5440e5f75424beb896a4d8c04ce09d Cr-Commit-Position: refs/heads/master@{#434210}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Only compile for CrOS. #

Patch Set 3 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -688 lines) Patch
M ash/BUILD.gn View 1 2 4 chunks +0 lines, -6 lines 0 comments Download
M ash/display/display_change_observer_chromeos.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
D ash/touch/touchscreen_util.h View 1 chunk +0 lines, -24 lines 0 comments Download
D ash/touch/touchscreen_util.cc View 1 chunk +0 lines, -284 lines 0 comments Download
D ash/touch/touchscreen_util_unittest.cc View 1 chunk +0 lines, -289 lines 0 comments Download
M ui/display/BUILD.gn View 1 2 6 chunks +8 lines, -4 lines 0 comments Download
A ui/display/chromeos/DEPS View 1 1 chunk +3 lines, -0 lines 0 comments Download
A + ui/display/chromeos/touchscreen_util.h View 1 1 chunk +7 lines, -7 lines 0 comments Download
A + ui/display/chromeos/touchscreen_util.cc View 1 13 chunks +18 lines, -18 lines 0 comments Download
A + ui/display/chromeos/touchscreen_util_unittest.cc View 1 11 chunks +57 lines, -54 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 27 (18 generated)
kylechar
+oshima for ash/display* and ui/display/* changes. +sadrul for ui/display/manager/DEPS
4 years, 1 month ago (2016-11-21 22:08:41 UTC) #3
sadrul
https://codereview.chromium.org/2520143002/diff/1/ui/display/BUILD.gn File ui/display/BUILD.gn (right): https://codereview.chromium.org/2520143002/diff/1/ui/display/BUILD.gn#newcode87 ui/display/BUILD.gn:87: "//ui/events/devices", Interesting. This doesn't introduce a cyclic dependency?
4 years, 1 month ago (2016-11-22 02:03:05 UTC) #4
sadrul
lgtm
4 years, 1 month ago (2016-11-22 03:00:02 UTC) #7
kylechar
https://codereview.chromium.org/2520143002/diff/1/ui/display/BUILD.gn File ui/display/BUILD.gn (right): https://codereview.chromium.org/2520143002/diff/1/ui/display/BUILD.gn#newcode87 ui/display/BUILD.gn:87: "//ui/events/devices", On 2016/11/22 02:03:05, sadrul wrote: > Interesting. This ...
4 years, 1 month ago (2016-11-22 13:32:36 UTC) #10
oshima
lgtm
4 years, 1 month ago (2016-11-22 21:48:32 UTC) #11
kylechar
Thanks!
4 years ago (2016-11-23 14:43:10 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2520143002/40001
4 years ago (2016-11-23 18:29:54 UTC) #23
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years ago (2016-11-23 18:40:34 UTC) #25
commit-bot: I haz the power
4 years ago (2016-11-23 18:45:53 UTC) #27
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/3ce955f57b5440e5f75424beb896a4d8c04ce09d
Cr-Commit-Position: refs/heads/master@{#434210}

Powered by Google App Engine
This is Rietveld 408576698