WindowManagerClient::AddAccelerator() should take an array

services/ui/common/accelerator_transport_util.h

Index: services/ui/common/accelerator_transport_util.h
diff --git a/services/ui/common/accelerator_transport_util.h b/services/ui/common/accelerator_transport_util.h
new file mode 100644
index 0000000000000000000000000000000000000000..70cb09c4cdabc50997674202c1a87eb95438f582
--- /dev/null
+++ b/services/ui/common/accelerator_transport_util.h
@@ -0,0 +1,23 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef SERVICES_UI_COMMON_ACCELERATOR_TRANSPORT_UTIL_H_

[mfomitchev, 2016/11/29 01:55:46]

Rather than creating a new file, perhaps rename
services/ui/common/event_matcher_util.* to
services/ui/common/accelerator_util.*, and put  AddAcceleratorHelper() in there

[thanhph, 2016/11/29 16:50:17]

Done, thanks!

+#define SERVICES_UI_COMMON_ACCELERATOR_TRANSPORT_UTIL_H_
+
+#include "services/ui/public/interfaces/event_matcher.mojom.h"
+#include "services/ui/public/interfaces/window_manager.mojom.h"
+
+namespace ash {
+namespace mus {
+
+// Adding an accelerator to a vector of accelerators.

[mfomitchev, 2016/11/29 01:55:45]

A little more detail would be nice, since there's a lot of args, e.g:
Construct accelerator from the provided |id| and |event_matcher| and add it to
the provided |accelerators| vector.

[thanhph, 2016/11/29 16:50:17]

Done, thanks!

+std::vector<ui::mojom::AcceleratorTransportPtr> AddAcceleratorHelper(
+    std::vector<ui::mojom::AcceleratorTransportPtr> accelerators,
+    uint32_t id,
+    ui::mojom::EventMatcherPtr event_matcher);
+
+}  // namespace mus
+}  // namespace ash
+
+#endif  // SERVICES_UI_COMMON_ACCELERATOR_TRANSPORT_UTIL_H_