services/ui/common/accelerator_transport_util.h - Issue 2520093003: WindowManagerClient::AddAccelerator() should take an array

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: services/ui/common/accelerator_transport_util.h

Issue 2520093003: WindowManagerClient::AddAccelerator() should take an array (Closed)

Patch Set: Modify helper to return vector and leverage helper in other files.Rename/format code. Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« ash/mus/accelerators/accelerator_controller_registrar.cc ('K') | « services/ui/common/BUILD.gn ('k') | services/ui/common/accelerator_transport_util.cc » ('j') | services/ui/common/accelerator_transport_util.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2015 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef SERVICES_UI_COMMON_ACCELERATOR_TRANSPORT_UTIL_H_
	mfomitchev 2016/11/29 01:55:46 Rather than creating a new file, perhaps rename se Rather than creating a new file, perhaps rename services/ui/common/event_matcher_util.* to services/ui/common/accelerator_util., and put AddAcceleratorHelper() in there thanhph* 2016/11/29 16:50:17 Done, thanks! Show quoted text On 2016/11/29 01:55:46, mfomitchev wrote: > Rather than creating a new file, perhaps rename > services/ui/common/event_matcher_util.* to > services/ui/common/accelerator_util.*, and put AddAcceleratorHelper() in there Done, thanks!
	6 #define SERVICES_UI_COMMON_ACCELERATOR_TRANSPORT_UTIL_H_

	7

	8 #include "services/ui/public/interfaces/event_matcher.mojom.h"

	9 #include "services/ui/public/interfaces/window_manager.mojom.h"

	10

	11 namespace ash {

	12 namespace mus {

	13

	14 // Adding an accelerator to a vector of accelerators.
	mfomitchev 2016/11/29 01:55:45 A little more detail would be nice, since there's A little more detail would be nice, since there's a lot of args, e.g: Construct accelerator from the provided \|id\| and \|event_matcher\| and add it to the provided \|accelerators\| vector. thanhph 2016/11/29 16:50:17 Done, thanks! Show quoted text On 2016/11/29 01:55:45, mfomitchev wrote: > A little more detail would be nice, since there's a lot of args, e.g: > Construct accelerator from the provided \|id\| and \|event_matcher\| and add it to > the provided \|accelerators\| vector. Done, thanks!
	15 std::vector<ui::mojom::AcceleratorTransportPtr> AddAcceleratorHelper(

	16 std::vector<ui::mojom::AcceleratorTransportPtr> accelerators,

	17 uint32_t id,

	18 ui::mojom::EventMatcherPtr event_matcher);

	19

	20 } // namespace mus

	21 } // namespace ash

	22

	23 #endif // SERVICES_UI_COMMON_ACCELERATOR_TRANSPORT_UTIL_H_

OLD	NEW