Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 2520053002: [Merge M-55] Disable Web Payments in WebView (Closed)

Created:
4 years, 1 month ago by please use gerrit instead
Modified:
4 years, 1 month ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2883
Project:
chromium
Visibility:
Public.

Description

[Merge M-55] Disable Web Payments in WebView Web Payments API requires Chrome UI, which is not available in WebView. This patch disabled Web Payments feature in WebView, so that feature-detection for "window.PaymentRequest" works as expected in JavaScript. BUG=667069 Review-Url: https://codereview.chromium.org/2519723002 Cr-Commit-Position: refs/heads/master@{#433540} (cherry picked from commit 04ae1ea7ce962ae6e1fd81b5a2efa0b45582467b) Committed: https://chromium.googlesource.com/chromium/src/+/e3ce76a4af496fa07a78ab50f9990b94ea01fdca

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+120 lines, -33 lines) Patch
M android_webview/browser/command_line_helper.h View 1 chunk +5 lines, -0 lines 0 comments Download
M android_webview/browser/command_line_helper.cc View 1 chunk +40 lines, -18 lines 0 comments Download
M android_webview/browser/command_line_helper_unittest.cc View 2 chunks +72 lines, -15 lines 0 comments Download
M android_webview/lib/main/aw_main_delegate.cc View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
please use gerrit instead
4 years, 1 month ago (2016-11-21 19:28:37 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e3ce76a4af496fa07a78ab50f9990b94ea01fdca.

Powered by Google App Engine
This is Rietveld 408576698