Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issue 2519723002: Disable Web Payments in WebView (Closed)

Created:
4 years, 1 month ago by please use gerrit instead
Modified:
3 years, 5 months ago
Reviewers:
Torne
CC:
chromium-reviews, android-webview-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable Web Payments in WebView Web Payments API requires Chrome UI, which is not available in WebView. This patch disabled Web Payments feature in WebView, so that feature-detection for "window.PaymentRequest" works as expected in JavaScript. BUG=667069 Committed: https://crrev.com/04ae1ea7ce962ae6e1fd81b5a2efa0b45582467b Cr-Commit-Position: refs/heads/master@{#433540}

Patch Set 1 #

Patch Set 2 : Fix typo disable/disabled #

Unified diffs Side-by-side diffs Delta from patch set Stats (+120 lines, -33 lines) Patch
M android_webview/browser/command_line_helper.h View 1 chunk +5 lines, -0 lines 0 comments Download
M android_webview/browser/command_line_helper.cc View 1 chunk +40 lines, -18 lines 0 comments Download
M android_webview/browser/command_line_helper_unittest.cc View 1 2 chunks +72 lines, -15 lines 0 comments Download
M android_webview/lib/main/aw_main_delegate.cc View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (12 generated)
please use gerrit instead
Torne, ptal.
4 years, 1 month ago (2016-11-19 20:38:11 UTC) #4
Torne
lgtm
4 years, 1 month ago (2016-11-21 12:49:03 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2519723002/20001
4 years, 1 month ago (2016-11-21 14:22:07 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-21 14:41:59 UTC) #15
commit-bot: I haz the power
4 years, 1 month ago (2016-11-21 14:45:15 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/04ae1ea7ce962ae6e1fd81b5a2efa0b45582467b
Cr-Commit-Position: refs/heads/master@{#433540}

Powered by Google App Engine
This is Rietveld 408576698