Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(574)

Issue 2520043004: Fix semantics of uploading HTML sources to 3D textures. (Closed)

Created:
4 years, 1 month ago by Ken Russell (switch to Gerrit)
Modified:
4 years, 1 month ago
Reviewers:
CC:
chromium-reviews, krit, drott+blinkwatch_chromium.org, blink-reviews-platform-graphics_chromium.org, dshwang, pdr+graphicswatchlist_chromium.org, jbroman, Justin Novosad, haraken, Rik, f(malita), blink-reviews, piman+watch_chromium.org, danakj+watch_chromium.org, ajuma+watch_chromium.org, Stephen Chennney, rwlbuis
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

Fix semantics of uploading HTML sources to 3D textures. The earlier code misinterpreted the spec as using the UNPACK_IMAGE_HEIGHT pixel storage parameter to slice the image's sub-rectangle into multiple layers of a 3D texture. The new semantics, which Firefox implements, walk the image sub-rectangle "depth" times through the source image, striding by UNPACK_IMAGE_HEIGHT rows each time -- this parameter defaulting to the height of the 3D texture. Tested with all conformance2/textures/ tests in https://github.com/KhronosGroup/WebGL/pull/2158 . (Removes WebGL conformance roll that was included on master branch) BUG=639145 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2511153002 Cr-Commit-Position: refs/heads/master@{#433079} (cherry picked from commit d481a01bc050798a91512bdad6a70fccf0cb27a3) Committed: https://chromium.googlesource.com/chromium/src/+/3fa4ac854ab92ab1f7904d1ea08d4abfaf1abca8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+164 lines, -104 lines) Patch
M third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.h View 1 chunk +23 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp View 10 chunks +24 lines, -49 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/gpu/WebGLImageConversion.h View 2 chunks +9 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/gpu/WebGLImageConversion.cpp View 10 chunks +108 lines, -46 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Ken Russell (switch to Gerrit)
4 years, 1 month ago (2016-11-23 01:23:46 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
3fa4ac854ab92ab1f7904d1ea08d4abfaf1abca8.

Powered by Google App Engine
This is Rietveld 408576698