Chromium Code Reviews
DescriptionFix semantics of uploading HTML sources to 3D textures.
The earlier code misinterpreted the spec as using the UNPACK_IMAGE_HEIGHT
pixel storage parameter to slice the image's sub-rectangle into multiple
layers of a 3D texture.
The new semantics, which Firefox implements, walk the image sub-rectangle
"depth" times through the source image, striding by UNPACK_IMAGE_HEIGHT
rows each time -- this parameter defaulting to the height of the 3D
texture.
Tested with all conformance2/textures/ tests in
https://github.com/KhronosGroup/WebGL/pull/2158 .
(Removes WebGL conformance roll that was included on master branch)
BUG=639145
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Review-Url: https://codereview.chromium.org/2511153002
Cr-Commit-Position: refs/heads/master@{#433079}
(cherry picked from commit d481a01bc050798a91512bdad6a70fccf0cb27a3)
Committed: https://chromium.googlesource.com/chromium/src/+/3fa4ac854ab92ab1f7904d1ea08d4abfaf1abca8
Patch Set 1 #
Messages
Total messages: 2 (1 generated)
|
||||||||||||||||||||||||||||||||||||||||||||||