Fix semantics of uploading HTML sources to 3D textures.

Fix semantics of uploading HTML sources to 3D textures.

The earlier code misinterpreted the spec as using the UNPACK_IMAGE_HEIGHT
pixel storage parameter to slice the image's sub-rectangle into multiple
layers of a 3D texture.

The new semantics, which Firefox implements, walk the image sub-rectangle
"depth" times through the source image, striding by UNPACK_IMAGE_HEIGHT
rows each time -- this parameter defaulting to the height of the 3D
texture.

Tested with all conformance2/textures/ tests in
https://github.com/KhronosGroup/WebGL/pull/2158 .

Incorporates needed WebGL conformance roll:

Roll WebGL b1a7540..453428f

https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/b1a7540..453428f

BUG=639145
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/d481a01bc050798a91512bdad6a70fccf0cb27a3
Cr-Commit-Position: refs/heads/master@{#433079}

[Ken Russell (switch to Gerrit), 2016-11-17 15:52:30]

Description was changed from

==========
Fix semantics of uploading HTML sources to 3D textures.

The earlier code misinterpreted the spec as using the UNPACK_IMAGE_HEIGHT
pixel storage parameter to slice the image's sub-rectangle into multiple
layers of a 3D texture.

The new semantics, which Firefox implements, walk the image sub-rectangle
"depth" times through the source image, striding by UNPACK_IMAGE_HEIGHT
rows each time -- this parameter defaulting to the height of the 3D
texture.

Tested with all conformance2/textures/ tests in ???.

BUG=639145
==========

to

==========
Fix semantics of uploading HTML sources to 3D textures.

The earlier code misinterpreted the spec as using the UNPACK_IMAGE_HEIGHT
pixel storage parameter to slice the image's sub-rectangle into multiple
layers of a 3D texture.

The new semantics, which Firefox implements, walk the image sub-rectangle
"depth" times through the source image, striding by UNPACK_IMAGE_HEIGHT
rows each time -- this parameter defaulting to the height of the 3D
texture.

Tested with all conformance2/textures/ tests in ???.

BUG=639145
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Ken Russell (switch to Gerrit), 2016-11-17 16:08:38]

Description was changed from

==========
Fix semantics of uploading HTML sources to 3D textures.

The earlier code misinterpreted the spec as using the UNPACK_IMAGE_HEIGHT
pixel storage parameter to slice the image's sub-rectangle into multiple
layers of a 3D texture.

The new semantics, which Firefox implements, walk the image sub-rectangle
"depth" times through the source image, striding by UNPACK_IMAGE_HEIGHT
rows each time -- this parameter defaulting to the height of the 3D
texture.

Tested with all conformance2/textures/ tests in ???.

BUG=639145
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Fix semantics of uploading HTML sources to 3D textures.

The earlier code misinterpreted the spec as using the UNPACK_IMAGE_HEIGHT
pixel storage parameter to slice the image's sub-rectangle into multiple
layers of a 3D texture.

The new semantics, which Firefox implements, walk the image sub-rectangle
"depth" times through the source image, striding by UNPACK_IMAGE_HEIGHT
rows each time -- this parameter defaulting to the height of the 3D
texture.

Tested with all conformance2/textures/ tests in
https://github.com/KhronosGroup/WebGL/pull/2158 .

BUG=639145
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Ken Russell (switch to Gerrit), 2016-11-17 16:10:01]

kbr@chromium.org changed reviewers:
+ kainino@chromium.org, zmo@chromium.org

[Ken Russell (switch to Gerrit), 2016-11-17 16:10:02]

Mo, Kai: please review. Thanks.

Note that this can't be tried until
https://github.com/KhronosGroup/WebGL/pull/2158 lands; I'll then incorporate a
WebGL conformance suite roll into this CL.

[Zhenyao Mo, 2016-11-17 16:34:10]

On 2016/11/17 16:10:02, Ken Russell wrote:
> Mo, Kai: please review. Thanks.
> 
> Note that this can't be tried until
> https://github.com/KhronosGroup/WebGL/pull/2158 lands; I'll then incorporate a
> WebGL conformance suite roll into this CL.

lgtm with webgl conformance roll included.

[Ken Russell (switch to Gerrit), 2016-11-17 16:35:46]

Description was changed from

==========
Fix semantics of uploading HTML sources to 3D textures.

The earlier code misinterpreted the spec as using the UNPACK_IMAGE_HEIGHT
pixel storage parameter to slice the image's sub-rectangle into multiple
layers of a 3D texture.

The new semantics, which Firefox implements, walk the image sub-rectangle
"depth" times through the source image, striding by UNPACK_IMAGE_HEIGHT
rows each time -- this parameter defaulting to the height of the 3D
texture.

Tested with all conformance2/textures/ tests in
https://github.com/KhronosGroup/WebGL/pull/2158 .

BUG=639145
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Fix semantics of uploading HTML sources to 3D textures.

The earlier code misinterpreted the spec as using the UNPACK_IMAGE_HEIGHT
pixel storage parameter to slice the image's sub-rectangle into multiple
layers of a 3D texture.

The new semantics, which Firefox implements, walk the image sub-rectangle
"depth" times through the source image, striding by UNPACK_IMAGE_HEIGHT
rows each time -- this parameter defaulting to the height of the 3D
texture.

Tested with all conformance2/textures/ tests in
https://github.com/KhronosGroup/WebGL/pull/2158 .

Incorporates needed WebGL conformance roll:

Roll WebGL b1a7540..453428f

https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/b1a754...

BUG=639145
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Ken Russell (switch to Gerrit), 2016-11-17 16:35:54]

The CQ bit was checked by kbr@chromium.org

[Ken Russell (switch to Gerrit), 2016-11-17 16:35:55]

The patchset sent to the CQ was uploaded after l-g-t-m from zmo@chromium.org
Link to the patchset: https://codereview.chromium.org/2511153002/#ps20001
(title: "Incorporated needed WebGL conformance roll.")

[commit-bot: I haz the power, 2016-11-17 16:36:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Kai Ninomiya, 2016-11-17 18:03:35]

lgtm

[commit-bot: I haz the power, 2016-11-17 18:20:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-17 18:20:06]

Try jobs failed on following builders:
  mac_optional_gpu_tests_rel on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_optional_gpu_...)

[Ken Russell (switch to Gerrit), 2016-11-17 21:36:22]

On 2016/11/17 18:20:06, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   mac_optional_gpu_tests_rel on master.tryserver.chromium.mac (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_optional_gpu_...)

It was a mistake to try to optimize uploads of sub-rectangles of ImageBitmaps at
the last minute. Undid this; these tests now pass again. I must not have tested
that change, though I thought I did.

[Ken Russell (switch to Gerrit), 2016-11-17 21:36:26]

The CQ bit was checked by kbr@chromium.org

[Ken Russell (switch to Gerrit), 2016-11-17 21:36:26]

The patchset sent to the CQ was uploaded after l-g-t-m from zmo@chromium.org,
kainino@chromium.org
Link to the patchset: https://codereview.chromium.org/2511153002/#ps40001
(title: "Remove attempted optimization of uploads of ImageBitmap
sub-rectangles.")

[commit-bot: I haz the power, 2016-11-17 21:38:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-17 23:30:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-17 23:30:25]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Ken Russell (switch to Gerrit), 2016-11-18 00:05:53]

The CQ bit was checked by kbr@chromium.org

[commit-bot: I haz the power, 2016-11-18 00:07:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-18 03:53:19]

Description was changed from

==========
Fix semantics of uploading HTML sources to 3D textures.

The earlier code misinterpreted the spec as using the UNPACK_IMAGE_HEIGHT
pixel storage parameter to slice the image's sub-rectangle into multiple
layers of a 3D texture.

The new semantics, which Firefox implements, walk the image sub-rectangle
"depth" times through the source image, striding by UNPACK_IMAGE_HEIGHT
rows each time -- this parameter defaulting to the height of the 3D
texture.

Tested with all conformance2/textures/ tests in
https://github.com/KhronosGroup/WebGL/pull/2158 .

Incorporates needed WebGL conformance roll:

Roll WebGL b1a7540..453428f

https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/b1a754...

BUG=639145
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Fix semantics of uploading HTML sources to 3D textures.

The earlier code misinterpreted the spec as using the UNPACK_IMAGE_HEIGHT
pixel storage parameter to slice the image's sub-rectangle into multiple
layers of a 3D texture.

The new semantics, which Firefox implements, walk the image sub-rectangle
"depth" times through the source image, striding by UNPACK_IMAGE_HEIGHT
rows each time -- this parameter defaulting to the height of the 3D
texture.

Tested with all conformance2/textures/ tests in
https://github.com/KhronosGroup/WebGL/pull/2158 .

Incorporates needed WebGL conformance roll:

Roll WebGL b1a7540..453428f

https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/b1a754...

BUG=639145
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[commit-bot: I haz the power, 2016-11-18 03:53:20]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-11-18 03:56:55]

Description was changed from

==========
Fix semantics of uploading HTML sources to 3D textures.

The earlier code misinterpreted the spec as using the UNPACK_IMAGE_HEIGHT
pixel storage parameter to slice the image's sub-rectangle into multiple
layers of a 3D texture.

The new semantics, which Firefox implements, walk the image sub-rectangle
"depth" times through the source image, striding by UNPACK_IMAGE_HEIGHT
rows each time -- this parameter defaulting to the height of the 3D
texture.

Tested with all conformance2/textures/ tests in
https://github.com/KhronosGroup/WebGL/pull/2158 .

Incorporates needed WebGL conformance roll:

Roll WebGL b1a7540..453428f

https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/b1a754...

BUG=639145
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Fix semantics of uploading HTML sources to 3D textures.

The earlier code misinterpreted the spec as using the UNPACK_IMAGE_HEIGHT
pixel storage parameter to slice the image's sub-rectangle into multiple
layers of a 3D texture.

The new semantics, which Firefox implements, walk the image sub-rectangle
"depth" times through the source image, striding by UNPACK_IMAGE_HEIGHT
rows each time -- this parameter defaulting to the height of the 3D
texture.

Tested with all conformance2/textures/ tests in
https://github.com/KhronosGroup/WebGL/pull/2158 .

Incorporates needed WebGL conformance roll:

Roll WebGL b1a7540..453428f

https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/b1a754...

BUG=639145
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/d481a01bc050798a91512bdad6a70fccf0cb27a3
Cr-Commit-Position: refs/heads/master@{#433079}
==========

[commit-bot: I haz the power, 2016-11-18 03:56:56]

Patchset 3 (id:??) landed as
https://crrev.com/d481a01bc050798a91512bdad6a70fccf0cb27a3
Cr-Commit-Position: refs/heads/master@{#433079}