[Mac] Implement frame.[color|inactiveColor].

[Mac] Implement frame.[color|inactiveColor].

This also removes --apps-use-native-frame.

BUG=339558
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267559

[tapted, 2014-04-29 00:43:28]

+chrome-apps-syd-reviews

https://codereview.chromium.org/251993002/diff/20001/chrome/browser/ui/cocoa/...
File chrome/browser/ui/cocoa/apps/native_app_window_cocoa.mm (right):

https://codereview.chromium.org/251993002/diff/20001/chrome/browser/ui/cocoa/...
chrome/browser/ui/cocoa/apps/native_app_window_cocoa.mm:232:
inactiveColor:(NSColor*)inactiveColor;
nit: indent should be minimum 4 spaces (even if it means colons don't align)

https://codereview.chromium.org/251993002/diff/20001/chrome/browser/ui/cocoa/...
chrome/browser/ui/cocoa/apps/native_app_window_cocoa.mm:254: NSRectFill(rect);
I think ShellCustomFrameNSWindow is still used when has_frame == true and
has_frame_color == false, in which case |color_| and |inactiveColor_| will still
be `nil`. It won't crash here... but I think it will draw a rectangle with the
clearColor set above when [nil foo] becomes a no-op.

https://codereview.chromium.org/251993002/diff/20001/chrome/browser/ui/cocoa/...
chrome/browser/ui/cocoa/apps/native_app_window_cocoa.mm:258:
inactiveColor:(NSColor*)inactiveColor {
nit: indent 1 more space

https://codereview.chromium.org/251993002/diff/20001/chrome/browser/ui/cocoa/...
chrome/browser/ui/cocoa/apps/native_app_window_cocoa.mm:331:
[ShellCustomFrameNSWindow class] : [ShellNSWindow class];
Does this mean any windows that are frame:true will be auto-upgraded to Native
(gray) borders? (is that a regression? i.e. should they stay white?)

https://codereview.chromium.org/251993002/diff/20001/chrome/browser/ui/cocoa/...
chrome/browser/ui/cocoa/apps/native_app_window_cocoa.mm:333: window_class =
[ShellFramelessNSWindow class];
note I think this will also call drawCustomFrameRect

https://codereview.chromium.org/251993002/diff/20001/chrome/browser/ui/cocoa/...
chrome/browser/ui/cocoa/apps/native_app_window_cocoa.mm:348:
[static_cast<ShellCustomFrameNSWindow*>(window)
nit: use base::mac::ObjCCastStrict for objective C objects (it's basically a
static_cast that's checked in debug builds).

[jackhou1, 2014-04-29 02:57:50]

https://codereview.chromium.org/251993002/diff/20001/chrome/browser/ui/cocoa/...
File chrome/browser/ui/cocoa/apps/native_app_window_cocoa.mm (right):

https://codereview.chromium.org/251993002/diff/20001/chrome/browser/ui/cocoa/...
chrome/browser/ui/cocoa/apps/native_app_window_cocoa.mm:232:
inactiveColor:(NSColor*)inactiveColor;
On 2014/04/29 00:43:29, tapted wrote:
> nit: indent should be minimum 4 spaces (even if it means colons don't align)

Done.

https://codereview.chromium.org/251993002/diff/20001/chrome/browser/ui/cocoa/...
chrome/browser/ui/cocoa/apps/native_app_window_cocoa.mm:254: NSRectFill(rect);
On 2014/04/29 00:43:29, tapted wrote:
> I think ShellCustomFrameNSWindow is still used when has_frame == true and
> has_frame_color == false, in which case |color_| and |inactiveColor_| will
still
> be `nil`. It won't crash here... but I think it will draw a rectangle with the
> clearColor set above when [nil foo] becomes a no-op.

Around line 330, where we choose the subclass of NSWindow.
ShellCustomFrameNSWindow is only used when there is a frame color. ShellNSWindow
is used for native frame, and ShellFramelessNSWindow for no frame.

https://codereview.chromium.org/251993002/diff/20001/chrome/browser/ui/cocoa/...
chrome/browser/ui/cocoa/apps/native_app_window_cocoa.mm:258:
inactiveColor:(NSColor*)inactiveColor {
On 2014/04/29 00:43:29, tapted wrote:
> nit: indent 1 more space

Done.

https://codereview.chromium.org/251993002/diff/20001/chrome/browser/ui/cocoa/...
chrome/browser/ui/cocoa/apps/native_app_window_cocoa.mm:331:
[ShellCustomFrameNSWindow class] : [ShellNSWindow class];
On 2014/04/29 00:43:29, tapted wrote:
> Does this mean any windows that are frame:true will be auto-upgraded to Native
> (gray) borders? (is that a regression? i.e. should they stay white?)

Nope, native frames will become the default.

https://codereview.chromium.org/251993002/diff/20001/chrome/browser/ui/cocoa/...
chrome/browser/ui/cocoa/apps/native_app_window_cocoa.mm:333: window_class =
[ShellFramelessNSWindow class];
On 2014/04/29 00:43:29, tapted wrote:
> note I think this will also call drawCustomFrameRect

Changed ShellFramelessNSWindow to subclass ShellNSWindow.

https://codereview.chromium.org/251993002/diff/20001/chrome/browser/ui/cocoa/...
chrome/browser/ui/cocoa/apps/native_app_window_cocoa.mm:348:
[static_cast<ShellCustomFrameNSWindow*>(window)
On 2014/04/29 00:43:29, tapted wrote:
> nit: use base::mac::ObjCCastStrict for objective C objects (it's basically a
> static_cast that's checked in debug builds).

Done.

[tapted, 2014-04-29 06:23:41]

lgtm

[jackhou1, 2014-05-01 13:56:28]

The CQ bit was checked by jackhou@chromium.org

[commit-bot: I haz the power, 2014-05-01 13:56:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jackhou@chromium.org/251993002/80001

[commit-bot: I haz the power, 2014-05-01 17:19:28]

Change committed as 267559

[jackhou1, 2014-05-03 03:08:26]

Reverted here https://codereview.chromium.org/265843005/
because this was failing on 10.7 bots with the following:

2014-05-01 15:52:56.722 browser_tests[4129:10103] -[NSThemeFrame
_fullScreenButtonOriginOriginal]: unrecognized selector sent to instance
0x78664ce0
[4129:65795:0501/155256:FATAL:chrome_browser_application_mac.mm(147)] Someone is
trying to raise an exception!  NSInvalidArgumentException reason -[NSThemeFrame
_fullScreenButtonOriginOriginal]: unrecognized selector sent to instance
0x78664ce0
0   libbase.dylib                       0x113623ef
base::debug::StackTrace::StackTrace() + 63
1   libbase.dylib                       0x1136244b
base::debug::StackTrace::StackTrace() + 43
2   libbase.dylib                       0x11407672
logging::LogMessage::~LogMessage() + 82
3   libbase.dylib                       0x114060eb
logging::LogMessage::~LogMessage() + 43
4   browser_tests                       0x014241cf
-[NSException(CrNSExceptionSwizzle) crInitWithName:reason:userInfo:] + 1471
5   CoreFoundation                      0x9c2fc3c9 +[NSException
exceptionWithName:reason:userInfo:] + 73
6   CoreFoundation                      0x9c398168 -[NSObject
doesNotRecognizeSelector:] + 248
7   CoreFoundation                      0x9c2e6da9 ___forwarding___ + 457
8   CoreFoundation                      0x9c2e6b72 _CF_forwarding_prep_0 + 50
9   browser_tests                       0x0324408c -[CustomFrameView
_fullScreenButtonOrigin] + 204
10  AppKit                              0x96408ed4 -[NSThemeFrame
_tileTitlebarAndRedisplay:] + 340
11  AppKit                              0x96446ac7 -[NSThemeFrame
_updateButtons] + 2908
12  AppKit                              0x969da307 -[NSWindow
_updateCollectionBehavior] + 471
13  AppKit                              0x9643afd7 -[NSWindow
setCollectionBehavior:] + 214
14  browser_tests                       0x03133e70 (anonymous
namespace)::SetFullScreenCollectionBehavior(NSWindow*, bool) + 144
15  browser_tests                       0x03137039
NativeAppWindowCocoa::SetContentSizeConstraints(gfx::Size const&, gfx::Size
const&) + 841
16  browser_tests                       0x03131dac
NativeAppWindowCocoa::NativeAppWindowCocoa(apps::AppWindow*,
apps::AppWindow::CreateParams const&) + 2140
17  browser_tests                       0x03132d57
NativeAppWindowCocoa::NativeAppWindowCocoa(apps::AppWindow*,
apps::AppWindow::CreateParams const&) + 71
18  browser_tests                       0x0312ffa5
ChromeAppWindowDelegate::CreateNativeAppWindowImpl(apps::AppWindow*,
apps::AppWindow::CreateParams const&) + 85
19  browser_tests                       0x0305e610
ChromeAppWindowDelegate::CreateNativeAppWindow(apps::AppWindow*,
apps::AppWindow::CreateParams const&) + 64
20  browser_tests                       0x056196b3 apps::AppWindow::Init(GURL
const&, apps::AppWindowContents*, apps::AppWindow::CreateParams const&) + 771
21  browser_tests                       0x0475626a
extensions::AppWindowCreateFunction::RunImpl() + 3434
22  browser_tests                       0x0519e07e ExtensionFunction::Run() + 46
23  browser_tests                       0x051a5e3b
extensions::ExtensionFunctionDispatcher::DispatchWithCallbackInternal(ExtensionHostMsg_Request_Params
const&, content::RenderViewHost*, content::RenderFrameHost*,
base::Callback\u003Cvoid ()(ExtensionFunction::ResponseType, base::ListValue
const&, std::string const&)> const&) + 2219
24  browser_tests                       0x051a5556
extensions::ExtensionFunctionDispatcher::Dispatch(ExtensionHostMsg_Request_Params
const&, content::RenderViewHost*) + 406
25  browser_tests                       0x05196769
extensions::ExtensionHost::OnRequest(ExtensionHostMsg_Request_Params const&) +
89
26  browser_tests                       0x051976c6 void
DispatchToMethod\u003Cextensions::ExtensionHost, void
(extensions::ExtensionHost::*)(ExtensionHostMsg_Request_Params const&),
ExtensionHostMsg_Request_Params>(extensions::ExtensionHost*, void
(extensions::ExtensionHost::*)(ExtensionHostMsg_Request_Params const&),
Tuple1\u003CExtensionHostMsg_Request_Params> const&) + 166
27  browser_tests                       0x051974e8 bool
ExtensionHostMsg_Request::Dispatch\u003Cextensions::ExtensionHost,
extensions::ExtensionHost, void
(extensions::ExtensionHost::*)(ExtensionHostMsg_Request_Params
const&)>(IPC::Message const*, extensions::ExtensionHost*,
extensions::ExtensionHost*, void
(extensions::ExtensionHost::*)(ExtensionHostMsg_Request_Params const&)) + 200
28  browser_tests                       0x05196392
extensions::ExtensionHost::OnMessageReceived(IPC::Message const&) + 418
29  browser_tests                       0x0519697f non-virtual thunk to
extensions::ExtensionHost::OnMessageReceived(IPC::Message const&) + 63
30  libcontent.dylib                    0x1de971ee
content::WebContentsImpl::OnMessageReceived(content::RenderViewHost*,
content::RenderFrameHost*, IPC::Message const&) + 478
31  libcontent.dylib                    0x1de96fd8
content::WebContentsImpl::OnMessageReceived(content::RenderViewHost*,
IPC::Message const&) + 88
32  libcontent.dylib                    0x1de98edd non-virtual thunk to
content::WebContentsImpl::OnMessageReceived(content::RenderViewHost*,
IPC::Message const&) + 77
33  libcontent.dylib                    0x1dc479b4
content::RenderViewHostImpl::OnMessageReceived(IPC::Message const&) + 324
34  libcontent.dylib                    0x1dc4c46f non-virtual thunk to
content::RenderViewHostImpl::OnMessageReceived(IPC::Message const&) + 63
35  libcontent.dylib                    0x1dc1af73
content::RenderProcessHostImpl::OnMessageReceived(IPC::Message const&) + 2195
36  libcontent.dylib                    0x1dc1b52f non-virtual thunk to
content::RenderProcessHostImpl::OnMessageReceived(IPC::Message const&) + 63
37  libipc.dylib                        0x25b91863
IPC::ChannelProxy::Context::OnDispatchMessage(IPC::Message const&) + 579
38  libipc.dylib                        0x25b9ae80
base::internal::RunnableAdapter\u003Cvoid
(IPC::ChannelProxy::Context::*)(IPC::Message
const&)>::Run(IPC::ChannelProxy::Context*, IPC::Message const&) + 160
39  libipc.dylib                        0x25b9ad7f
base::internal::InvokeHelper\u003Cfalse, void,
base::internal::RunnableAdapter\u003Cvoid
(IPC::ChannelProxy::Context::*)(IPC::Message const&)>, void
()(IPC::ChannelProxy::Context* const&, IPC::Message
const&)>::MakeItSo(base::internal::RunnableAdapter\u003Cvoid
(IPC::ChannelProxy::Context::*)(IPC::Message const&)>,
IPC::ChannelProxy::Context* const&, IPC::Message const&) + 95
40  libipc.dylib                        0x25b9acb4
base::internal::Invoker\u003C2,
base::internal::BindState\u003Cbase::internal::RunnableAdapter\u003Cvoid
(IPC::ChannelProxy::Context::*)(IPC::Message const&)>, void
()(IPC::ChannelProxy::Context*, IPC::Message const&), void
()(IPC::ChannelProxy::Context*, IPC::Message)>, void
()(IPC::ChannelProxy::Context*, IPC::Message
const&)>::Run(base::internal::BindStateBase*) + 148
41  libbase.dylib                       0x1134bbab base::Callback\u003Cvoid
()()>::Run() const + 75
42  libbase.dylib                       0x1144ab3a
base::MessageLoop::RunTask(base::PendingTask const&) + 1498
43  libbase.dylib                       0x1144b002
base::MessageLoop::DeferOrRunPendingTask(base::PendingTask const&) + 98
44  libbase.dylib                       0x1144b2d1 base::MessageLoop::DoWork() +
321
45  libbase.dylib                       0x1131d6a8
base::MessagePumpCFRunLoopBase::RunWork() + 168
46  libbase.dylib                       0x1131cc71
base::MessagePumpCFRunLoopBase::RunWorkSource(void*) + 49
47  CoreFoundation                      0x9c2613df
__CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ + 15
48  CoreFoundation                      0x9c260d96 __CFRunLoopDoSources0 + 246
49  CoreFoundation                      0x9c28ac68 __CFRunLoopRun + 1112
50  CoreFoundation                      0x9c28a47c CFRunLoopRunSpecific + 332
51  CoreFoundation                      0x9c28a328 CFRunLoopRunInMode + 120
52  HIToolbox                           0x9013a17f RunCurrentEventLoopInMode +
318
53  HIToolbox                           0x901414e7 ReceiveNextEventCommon + 381
54  HIToolbox                           0x90141356
BlockUntilNextEventMatchingListInMode + 88
55  AppKit                              0x962aba9c _DPSNextEvent + 678
56  AppKit                              0x962ab306 -[NSApplication
nextEventMatchingMask:untilDate:inMode:dequeue:] + 113
57  AppKit                              0x962a7675 -[NSApplication run] + 911
58  libbase.dylib                       0x1131e642
base::MessagePumpNSApplication::DoRun(base::MessagePump::Delegate*) + 434
59  libbase.dylib                       0x1131d308
base::MessagePumpCFRunLoopBase::Run(base::MessagePump::Delegate*) + 104
60  libbase.dylib                       0x1144a21e
base::MessageLoop::RunHandler() + 318
61  libbase.dylib                       0x114bd1d8 base::RunLoop::Run() + 72