Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Unified Diff: chrome/browser/resources/settings/languages_page/add_languages_dialog.html

Issue 2519853005: MD Settings: Enable to search "Add languages" list. (Closed)
Patch Set: Fix to follow JavaScript Style Guide Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/languages_page/add_languages_dialog.html
diff --git a/chrome/browser/resources/settings/languages_page/add_languages_dialog.html b/chrome/browser/resources/settings/languages_page/add_languages_dialog.html
index 1d52ea16af7396681d63ba57c73066766bb8c898..0365b9610261f5d118b2966d9640227788f6a5fd 100644
--- a/chrome/browser/resources/settings/languages_page/add_languages_dialog.html
+++ b/chrome/browser/resources/settings/languages_page/add_languages_dialog.html
@@ -1,6 +1,8 @@
<link rel="import" href="chrome://resources/cr_elements/cr_dialog/cr_dialog.html">
<link rel="import" href="chrome://resources/html/polymer.html">
+<link rel="import" href="chrome://resources/polymer/v1_0/iron-input/iron-input.html">
<link rel="import" href="chrome://resources/polymer/v1_0/iron-list/iron-list.html">
+<link rel="import" href="chrome://resources/polymer/v1_0/paper-input/paper-input-container.html">
michaelpg 2016/12/01 20:40:13 alphabetize (move below paper-checkbox)
<link rel="import" href="chrome://resources/polymer/v1_0/paper-button/paper-button.html">
<link rel="import" href="chrome://resources/polymer/v1_0/paper-checkbox/paper-checkbox.html">
<link rel="import" href="/languages_page/languages.html">
@@ -29,10 +31,12 @@
<dialog is="cr-dialog" id="dialog">
<div class="title">$i18n{addLanguagesDialogTitle}</div>
<div class="body">
- <!-- TODO(michaelpg): Dynamic language search/filtering. -->
- <iron-list class="ripple-padding" scroll-target="[[$$('.body')]]"
+ <paper-input-container>
michaelpg 2016/12/02 03:56:41 +dpapad to figure out the best way to add a filter
+ <input is="iron-input" bind-value="{{filterValue_}}">
+ </paper-input-container>
+ <iron-list class="ripple-padding" scroll-target="[[$$('.ripple-padding')]]"
michaelpg 2016/12/01 20:40:13 keep to 80-column lines (e.g., break before scroll
items="[[getAvailableLanguages_(
- languages.supported, languages.enabled.*)]]">
+ languages.supported, languages.enabled.*, filterValue_)]]">
<template>
<paper-checkbox class="list-item" checked="[[willAdd_(item.code)]]"
title$="[[item.nativeDisplayName]]"

Powered by Google App Engine
This is Rietveld 408576698