third_party/WebKit/Source/web/tests/sim/SimRequest.cpp - Issue 2519843002: Update ResourceResponse::encodedDataLength when response is completed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/tests/sim/SimRequest.cpp

Issue 2519843002: Update ResourceResponse::encodedDataLength when response is completed (Closed)

Patch Set: Update ResourceResponse::encodedDataLength when response is completed Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/tests/sim/SimRequest.cpp

diff --git a/third_party/WebKit/Source/web/tests/sim/SimRequest.cpp b/third_party/WebKit/Source/web/tests/sim/SimRequest.cpp

index 2be8e69599862da7300a3e8bc13acf09eeb50342..df46ca526a98ee231e1cd72ea290b4e5aaeea3bb 100644

--- a/third_party/WebKit/Source/web/tests/sim/SimRequest.cpp

+++ b/third_party/WebKit/Source/web/tests/sim/SimRequest.cpp

@@ -61,7 +61,7 @@ void SimRequest::write(const String& data) {

void SimRequest::finish() {

DCHECK(m_isReady);

if (m_error.reason) {

- m_client->didFail(m_loader, m_error);

+ m_client->didFail(m_loader, m_error, m_totalEncodedDataLength);

} else {

// TODO(esprehn): Is claiming a request time of 0 okay for tests?

m_client->didFinishLoading(m_loader, 0, m_totalEncodedDataLength);