Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 2519823006: Chromad: Add authentication flow (Closed)

Created:
4 years ago by Roman Sorokin (ftl)
Modified:
3 years, 12 months ago
CC:
chromium-reviews, alemate+watch_chromium.org, hashimoto+watch_chromium.org, achuith+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Chromad: Add authentication flow Don't allow Google accounts on Active Directory enrolled devices. Always enforce online auth for the Active Directory accounts. Add new type of AccountId for Active directory. The account_ids should be fixed properly, once mirgration to GaiaIds will be done BUG=656992 TEST=manual CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/7ebd295d2ce1f07a33b4b4231c8f81963a574358 Cr-Commit-Position: refs/heads/master@{#440631}

Patch Set 1 #

Total comments: 20

Patch Set 2 : Rebased on top of "Add account_type into AccountId" #

Patch Set 3 : Comments #

Patch Set 4 : Fix profile creation, mojo types + rebase. #

Total comments: 8

Patch Set 5 : s/AD/ActiveDirectory, s/LOG/DLOG #

Total comments: 2

Patch Set 6 : Rename HandleAdAuth. Use system_api enums #

Unified diffs Side-by-side diffs Delta from patch set Stats (+328 lines, -48 lines) Patch
M ash/public/interfaces/session_controller.mojom View 1 2 3 4 1 chunk +3 lines, -0 lines 0 comments Download
M ash/public/interfaces/session_controller_traits.h View 1 2 3 4 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/helper.h View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/helper.cc View 1 2 3 4 3 chunks +26 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/screens/user_selection_screen.cc View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/session/user_session_manager.cc View 1 2 3 4 5 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/login/offline_ad_login.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/login/screen_gaia_signin.html View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/login/screen_gaia_signin.js View 1 2 3 7 chunks +50 lines, -5 lines 0 comments Download
M chrome/browser/resources/gaia_auth_host/authenticator.js View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/enrollment_screen_handler.cc View 1 2 3 3 chunks +3 lines, -24 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.h View 1 2 3 4 5 3 chunks +16 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc View 1 2 3 4 5 8 chunks +81 lines, -0 lines 0 comments Download
M chromeos/dbus/auth_policy_client.h View 1 2 3 4 5 3 chunks +16 lines, -3 lines 0 comments Download
M chromeos/dbus/auth_policy_client.cc View 1 2 3 4 5 5 chunks +42 lines, -5 lines 0 comments Download
M chromeos/dbus/fake_auth_policy_client.h View 1 2 3 1 chunk +5 lines, -2 lines 0 comments Download
M chromeos/dbus/fake_auth_policy_client.cc View 1 2 3 4 5 2 chunks +10 lines, -1 line 0 comments Download
M chromeos/login/auth/cryptohome_authenticator.cc View 1 2 3 4 2 chunks +8 lines, -1 line 0 comments Download
M chromeos/login/auth/user_context.h View 1 2 3 4 1 chunk +3 lines, -1 line 0 comments Download
M components/user_manager/user.h View 1 2 3 4 1 chunk +3 lines, -0 lines 0 comments Download
M components/user_manager/user.cc View 1 2 3 4 6 chunks +26 lines, -2 lines 0 comments Download
M components/user_manager/user_manager_base.cc View 1 2 3 4 2 chunks +5 lines, -2 lines 0 comments Download
M components/user_manager/user_type.h View 1 2 3 4 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 55 (31 generated)
Roman Sorokin (ftl)
PTAL
4 years ago (2016-11-23 14:13:37 UTC) #5
Alexander Alekseev
https://codereview.chromium.org/2519823006/diff/1/chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc File chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc (right): https://codereview.chromium.org/2519823006/diff/1/chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc#newcode506 chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc:506: AccountId ac_id(GetAccountId(username, uid)); Could you add account_type parameter to ...
4 years ago (2016-11-24 07:12:40 UTC) #8
Roman Sorokin (ftl)
https://codereview.chromium.org/2519823006/diff/1/chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc File chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc (right): https://codereview.chromium.org/2519823006/diff/1/chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc#newcode506 chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc:506: AccountId ac_id(GetAccountId(username, uid)); On 2016/11/24 07:12:40, Alexander Alekseev wrote: ...
4 years ago (2016-11-24 15:22:27 UTC) #9
Roman Sorokin (ftl)
xiyuan@chromium.org: Please take a look
4 years ago (2016-11-24 16:43:51 UTC) #11
Alexander Alekseev
https://codereview.chromium.org/2519823006/diff/1/chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc File chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc (right): https://codereview.chromium.org/2519823006/diff/1/chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc#newcode506 chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc:506: AccountId ac_id(GetAccountId(username, uid)); On 2016/11/24 15:22:26, Roman Sorokin wrote: ...
4 years ago (2016-11-25 08:07:07 UTC) #13
hashimoto
chromeos/dbus lgtm https://codereview.chromium.org/2519823006/diff/1/chromeos/dbus/auth_policy_client.h File chromeos/dbus/auth_policy_client.h (right): https://codereview.chromium.org/2519823006/diff/1/chromeos/dbus/auth_policy_client.h#newcode16 chromeos/dbus/auth_policy_client.h:16: namespace authpolicy { nit: Please put a ...
4 years ago (2016-11-28 03:28:51 UTC) #15
xiyuan
lgtm but please wait for alemate@ https://codereview.chromium.org/2519823006/diff/1/chrome/browser/chromeos/login/helper.cc File chrome/browser/chromeos/login/helper.cc (right): https://codereview.chromium.org/2519823006/diff/1/chrome/browser/chromeos/login/helper.cc#newcode105 chrome/browser/chromeos/login/helper.cc:105: } nit: insert ...
4 years ago (2016-11-28 23:43:05 UTC) #16
Roman Sorokin (ftl)
https://codereview.chromium.org/2519823006/diff/1/chrome/browser/chromeos/login/helper.cc File chrome/browser/chromeos/login/helper.cc (right): https://codereview.chromium.org/2519823006/diff/1/chrome/browser/chromeos/login/helper.cc#newcode105 chrome/browser/chromeos/login/helper.cc:105: } On 2016/11/28 23:43:05, xiyuan wrote: > nit: insert ...
4 years ago (2016-12-02 12:35:13 UTC) #17
Roman Sorokin (ftl)
jam@chromium.org: Please review changes in ash/public/interfaces/* Thanks!
4 years ago (2016-12-16 14:26:44 UTC) #25
jam
On 2016/12/16 14:26:44, Roman Sorokin wrote: > mailto:jam@chromium.org: Please review changes in > ash/public/interfaces/* > ...
4 years ago (2016-12-16 18:20:53 UTC) #28
Roman Sorokin (ftl)
4 years ago (2016-12-19 13:54:35 UTC) #30
Roman Sorokin (ftl)
dcheng@, please review ash/public/interfaces/session_controller.mojom
4 years ago (2016-12-19 13:57:27 UTC) #32
Roman Sorokin (ftl)
oshima@chromium.org: Please review changes in ash/public/interfaces/session_controller_traits.h
4 years ago (2016-12-19 13:58:34 UTC) #34
dcheng
https://codereview.chromium.org/2519823006/diff/60001/ash/public/interfaces/session_controller.mojom File ash/public/interfaces/session_controller.mojom (right): https://codereview.chromium.org/2519823006/diff/60001/ash/public/interfaces/session_controller.mojom#newcode64 ash/public/interfaces/session_controller.mojom:64: AD, Nit: Let's write this as ACTIVE_DIRECTORY, per the ...
4 years ago (2016-12-20 09:26:26 UTC) #35
Roman Sorokin (ftl)
dcheng@, PTAL. Thanks! https://codereview.chromium.org/2519823006/diff/60001/ash/public/interfaces/session_controller.mojom File ash/public/interfaces/session_controller.mojom (right): https://codereview.chromium.org/2519823006/diff/60001/ash/public/interfaces/session_controller.mojom#newcode64 ash/public/interfaces/session_controller.mojom:64: AD, On 2016/12/20 09:26:26, dcheng wrote: ...
4 years ago (2016-12-20 12:43:59 UTC) #38
dcheng
mojo lgtm
4 years ago (2016-12-20 19:52:20 UTC) #41
Alexander Alekseev
lgtm https://codereview.chromium.org/2519823006/diff/80001/chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc File chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc (right): https://codereview.chromium.org/2519823006/diff/80001/chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc#newcode502 chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc:502: void GaiaScreenHandler::HandleAdAuth(const std::string& username, This does not handle ...
4 years ago (2016-12-21 15:03:13 UTC) #42
Roman Sorokin (ftl)
Hi Dan, Could you please review ash/public/interfaces/session_controller_traits.h? Seems like all the other owners are OOO. ...
4 years ago (2016-12-21 17:41:37 UTC) #44
Daniel Erat
rubberstamp lgtm for ash/
4 years ago (2016-12-21 18:23:24 UTC) #45
Thiemo Nagel
Note that for a logged-in user, chrome://policy device policy status shows "Invalid request or request ...
4 years ago (2016-12-22 11:40:09 UTC) #46
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2519823006/100001
3 years, 12 months ago (2016-12-23 13:30:16 UTC) #49
Roman Sorokin (ftl)
https://codereview.chromium.org/2519823006/diff/80001/chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc File chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc (right): https://codereview.chromium.org/2519823006/diff/80001/chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc#newcode502 chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc:502: void GaiaScreenHandler::HandleAdAuth(const std::string& username, On 2016/12/21 15:03:13, Alexander Alekseev ...
3 years, 12 months ago (2016-12-23 13:30:22 UTC) #50
commit-bot: I haz the power
Committed patchset #6 (id:100001)
3 years, 12 months ago (2016-12-23 15:46:58 UTC) #53
commit-bot: I haz the power
3 years, 12 months ago (2016-12-23 15:49:09 UTC) #55
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/7ebd295d2ce1f07a33b4b4231c8f81963a574358
Cr-Commit-Position: refs/heads/master@{#440631}

Powered by Google App Engine
This is Rietveld 408576698