Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 2519823004: Passing extra flags through to execution in perf test isolate script. (Closed)

Created:
4 years, 1 month ago by eyaich1
Modified:
4 years, 1 month ago
Reviewers:
Paweł Hajdan Jr.
CC:
chromium-reviews, dtu
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Passing extra flags through to execution in perf test isolate script. Committed: https://crrev.com/ecd6f661a26d9e0f7e9e710b4179acbf5b99d9c4 Cr-Commit-Position: refs/heads/master@{#433909}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M testing/scripts/run_gtest_perf_test.py View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
eyaich1
4 years, 1 month ago (2016-11-22 15:58:16 UTC) #2
Paweł Hajdan Jr.
LGTM Parsing args this way is not ideal (I'd suggest for example nargs='*', as used ...
4 years, 1 month ago (2016-11-22 16:44:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2519823004/1
4 years, 1 month ago (2016-11-22 16:46:44 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-22 17:47:15 UTC) #7
commit-bot: I haz the power
4 years, 1 month ago (2016-11-22 17:52:14 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ecd6f661a26d9e0f7e9e710b4179acbf5b99d9c4
Cr-Commit-Position: refs/heads/master@{#433909}

Powered by Google App Engine
This is Rietveld 408576698