Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Unified Diff: testing/scripts/run_gtest_perf_test.py

Issue 2519823004: Passing extra flags through to execution in perf test isolate script. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: testing/scripts/run_gtest_perf_test.py
diff --git a/testing/scripts/run_gtest_perf_test.py b/testing/scripts/run_gtest_perf_test.py
index ac43ec75e0eb8327ca3a36e299b22b33b3d2b10b..5ad754e1dbc6e6cc50fd15c85db437ded9496c45 100755
--- a/testing/scripts/run_gtest_perf_test.py
+++ b/testing/scripts/run_gtest_perf_test.py
@@ -86,12 +86,15 @@ def main():
rc = 0
try:
executable = rest_args[0]
+ extra_flags = []
+ if len(rest_args) > 1:
+ extra_flags = rest_args[1:]
if IsWindows():
executable = '.\%s.exe' % executable
else:
executable = './%s' % executable
with common.temporary_file() as tempfile_path:
- valid = (common.run_command_with_output([executable],
+ valid = (common.run_command_with_output([executable] + extra_flags,
env=env, stdoutfile=tempfile_path) == 0)
# Now get the correct json format from the stdout to write to the
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698