Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(462)

Issue 2519793002: Add IPA Fonts to install-build-deps.*. (Closed)

Created:
4 years, 1 month ago by Jack Bates
Modified:
4 years, 1 month ago
Reviewers:
Lei Zhang, Nico, Daniel Erat
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add IPA Fonts to install-build-deps.*. I'm preparing to replace kochi-gothic.ttf and kochi-mincho.ttf, which were deprecated [1] and dropped from Debian and Ubuntu [2]. [1] https://packages.debian.org/wheezy/ttf-kochi-gothic [2] 726382 #33">https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=726382 #33 BUG=665515 Committed: https://crrev.com/f3d98882c70a1b44431bf3e75b457c56d6e02347 Cr-Commit-Position: refs/heads/master@{#433604}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M build/experimental/install-build-deps.py View 1 chunk +1 line, -0 lines 0 comments Download
M build/install-build-deps.sh View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
Jack Bates
I plan to: 1) Land this CL. 2) Send a PSA to chromium-dev asking developers ...
4 years, 1 month ago (2016-11-20 23:55:17 UTC) #3
Daniel Erat
lgtm (but i'm probably not an owner for any of this)
4 years, 1 month ago (2016-11-21 15:25:52 UTC) #4
Nico
The replacements for the deprecated fonts are available on the lowest ubuntu version that we ...
4 years, 1 month ago (2016-11-21 15:53:06 UTC) #5
Jack Bates
On 2016/11/21 15:53:06, Nico wrote: > The replacements for the deprecated fonts are available on ...
4 years, 1 month ago (2016-11-21 17:18:49 UTC) #6
Lei Zhang
On 2016/11/21 17:18:49, Jack Bates wrote: > On 2016/11/21 15:53:06, Nico wrote: > > The ...
4 years, 1 month ago (2016-11-21 19:06:01 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2519793002/1
4 years, 1 month ago (2016-11-21 19:20:50 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-21 19:34:36 UTC) #12
commit-bot: I haz the power
4 years, 1 month ago (2016-11-21 19:40:50 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f3d98882c70a1b44431bf3e75b457c56d6e02347
Cr-Commit-Position: refs/heads/master@{#433604}

Powered by Google App Engine
This is Rietveld 408576698