Replace kochi-*.ttf with IPA Fonts. (Reland)

Replace kochi-*.ttf with IPA Fonts. (Reland)

kochi-gothic.ttf and kochi-mincho.ttf were deprecated [1]
and dropped from Debian and Ubuntu [2].
They were replaced with ipag.ttf and ipam.ttf (fonts-ipafont package).

[1] https://packages.debian.org/wheezy/ttf-kochi-gothic
[2] 726382
#33">https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=726382
#33

BUG=665515
Committed: https://crrev.com/a15698acc363af3e3b28543135e765019ef709a1
Cr-Commit-Position: refs/heads/master@{#432306}

[Jack Bates, 2016-11-15 18:41:48]

Description was changed from

==========
Replace kochi-*.ttf with IPA Fonts.

kochi-gothic.ttf and kochi-mincho.ttf were deprecated [1]
and dropped from Debian and Ubuntu [2].
They were replaced with ipag.ttf and ipam.ttf (fonts-ipafont package).

[1] https://packages.debian.org/wheezy/ttf-kochi-gothic
[2] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=726382#33

BUG=665515
==========

to

==========
Replace kochi-*.ttf with IPA Fonts.

kochi-gothic.ttf and kochi-mincho.ttf were deprecated [1]
and dropped from Debian and Ubuntu [2].
They were replaced with ipag.ttf and ipam.ttf (fonts-ipafont package).

[1] https://packages.debian.org/wheezy/ttf-kochi-gothic
[2] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=726382#33

BUG=665515
==========

[Jack Bates, 2016-11-15 18:41:48]

jack@nottheoilrig.com changed reviewers:
+ thomasanderson@chromium.org

[Jack Bates, 2016-11-15 18:45:19]

I picked Thomas Anderson to review this because of your work on issue 621695. Is
there a better choice?

[Tom (Use chromium acct), 2016-11-15 19:04:33]

thomasanderson@google.com changed reviewers:
+ asvitkine@chromium.org, derat@chromium.org, msw@chromium.org,
thomasanderson@google.com

[Tom (Use chromium acct), 2016-11-15 19:04:34]

Hi jack@, unfortunately I don't have any OWNERS power here

+ some font folks from ui/gfx/OWNERS

[Daniel Erat, 2016-11-15 19:12:54]

thanks! mind also updating build/install-build-deps.sh (and
build/experimental/install-build-deps.py, i guess) to install the new package?

[msw, 2016-11-15 19:13:56]

The CQ bit was checked by msw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-15 19:14:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[msw, 2016-11-15 19:15:43]

I'll leave review to Dan, here's more knowledgeable here.

https://codereview.chromium.org/2500063003/diff/1/AUTHORS
File AUTHORS (right):

https://codereview.chromium.org/2500063003/diff/1/AUTHORS#newcode282
AUTHORS:282: Jack Bates <jack@nottheoilrig.com>
You have indeed signed the CLA, so this is fine.

[commit-bot: I haz the power, 2016-11-15 19:26:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-15 19:26:58]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[Jack Bates, 2016-11-15 20:03:13]

On 2016/11/15 19:12:54, Daniel Erat wrote:
> thanks! mind also updating build/install-build-deps.sh (and
> build/experimental/install-build-deps.py, i guess) to install the new package?

Done.

[Daniel Erat, 2016-11-15 20:06:53]

https://codereview.chromium.org/2500063003/diff/20001/build/install-build-dep...
File build/install-build-deps.sh (right):

https://codereview.chromium.org/2500063003/diff/20001/build/install-build-dep...
build/install-build-deps.sh:101: flex fonts-ipafont fonts-thai-tlwg g++ git-core
git-svn gperf language-pack-da
nit: please reformat this to fit within 80 columns, e.g. in vim, shift-v to
enter visual line mode, j/k to highlight the whole string, then "gq" to reflow

[Jack Bates, 2016-11-15 20:14:38]

https://codereview.chromium.org/2500063003/diff/20001/build/install-build-dep...
File build/install-build-deps.sh (right):

https://codereview.chromium.org/2500063003/diff/20001/build/install-build-dep...
build/install-build-deps.sh:101: flex fonts-ipafont fonts-thai-tlwg g++ git-core
git-svn gperf language-pack-da
On 2016/11/15 20:06:53, Daniel Erat wrote:
> nit: please reformat this to fit within 80 columns, e.g. in vim, shift-v to
> enter visual line mode, j/k to highlight the whole string, then "gq" to reflow

Done.

[Daniel Erat, 2016-11-15 20:38:50]

lgtm

[Daniel Erat, 2016-11-15 20:39:28]

The CQ bit was checked by derat@chromium.org

[commit-bot: I haz the power, 2016-11-15 20:39:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-15 20:53:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-15 20:53:59]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Jack Bates, 2016-11-15 21:56:26]

On 2016/11/15 19:15:43, msw wrote:
> I'll leave review to Dan, here's more knowledgeable here.
> 
> https://codereview.chromium.org/2500063003/diff/1/AUTHORS
> File AUTHORS (right):
> 
> https://codereview.chromium.org/2500063003/diff/1/AUTHORS#newcode282
> AUTHORS:282: Jack Bates <mailto:jack@nottheoilrig.com>
> You have indeed signed the CLA, so this is fine.

Thanks, but I think this needs LGTM from an OWNER of fontconfig_util_linux.cc
(and install-build-deps.*)?

[Daniel Erat, 2016-11-15 22:02:11]

derat@chromium.org changed reviewers:
+ thakis@chromium.org

[Daniel Erat, 2016-11-15 22:02:12]

asvitkine@, mind reviewing for ui/gfx? i'll send an additional change to add
myself as an owner of the file that's being modified there.

thakis@, can you review the package name changes in build/?

[Daniel Erat, 2016-11-15 22:04:36]

(oh, or mike can rubber-stamp it for ui/gfx...)

[Nico, 2016-11-15 22:05:58]

rs-lgtm everything

[msw, 2016-11-15 22:09:22]

lgtm

[Daniel Erat, 2016-11-15 22:09:51]

The CQ bit was checked by derat@chromium.org

[commit-bot: I haz the power, 2016-11-15 22:10:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-15 22:44:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-15 22:44:07]

Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[Jack Bates, 2016-11-15 23:04:44]

The CQ bit was checked by jack@nottheoilrig.com

[commit-bot: I haz the power, 2016-11-15 23:05:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-15 23:30:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-15 23:30:50]

Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[Jack Bates, 2016-11-15 23:51:21]

The CQ bit was checked by jack@nottheoilrig.com

[commit-bot: I haz the power, 2016-11-15 23:51:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-16 00:15:23]

Description was changed from

==========
Replace kochi-*.ttf with IPA Fonts.

kochi-gothic.ttf and kochi-mincho.ttf were deprecated [1]
and dropped from Debian and Ubuntu [2].
They were replaced with ipag.ttf and ipam.ttf (fonts-ipafont package).

[1] https://packages.debian.org/wheezy/ttf-kochi-gothic
[2] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=726382#33

BUG=665515
==========

to

==========
Replace kochi-*.ttf with IPA Fonts.

kochi-gothic.ttf and kochi-mincho.ttf were deprecated [1]
and dropped from Debian and Ubuntu [2].
They were replaced with ipag.ttf and ipam.ttf (fonts-ipafont package).

[1] https://packages.debian.org/wheezy/ttf-kochi-gothic
[2] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=726382#33

BUG=665515
==========

[commit-bot: I haz the power, 2016-11-16 00:15:26]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-11-16 00:17:48]

Description was changed from

==========
Replace kochi-*.ttf with IPA Fonts.

kochi-gothic.ttf and kochi-mincho.ttf were deprecated [1]
and dropped from Debian and Ubuntu [2].
They were replaced with ipag.ttf and ipam.ttf (fonts-ipafont package).

[1] https://packages.debian.org/wheezy/ttf-kochi-gothic
[2] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=726382#33

BUG=665515
==========

to

==========
Replace kochi-*.ttf with IPA Fonts.

kochi-gothic.ttf and kochi-mincho.ttf were deprecated [1]
and dropped from Debian and Ubuntu [2].
They were replaced with ipag.ttf and ipam.ttf (fonts-ipafont package).

[1] https://packages.debian.org/wheezy/ttf-kochi-gothic
[2] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=726382#33

BUG=665515

Committed: https://crrev.com/a15698acc363af3e3b28543135e765019ef709a1
Cr-Commit-Position: refs/heads/master@{#432306}
==========

[commit-bot: I haz the power, 2016-11-16 00:17:49]

Patchset 3 (id:??) landed as
https://crrev.com/a15698acc363af3e3b28543135e765019ef709a1
Cr-Commit-Position: refs/heads/master@{#432306}

[horo, 2016-11-16 03:41:41]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2504863002/ by horo@chromium.org.

The reason for reverting is: Looks like caused many failures in webkit_tests.

BUG=665693.

[Jack Bates, 2016-11-16 20:54:58]

On 2016/11/16 03:41:41, horo (JP-TOK sheriff Nov15-16) wrote:
> A revert of this CL (patchset #3 id:40001) has been created in
> https://codereview.chromium.org/2504863002/ by mailto:horo@chromium.org.
> 
> The reason for reverting is: Looks like caused many failures in webkit_tests.
> 
> BUG=665693.

I think I need Infra's help adding the fonts-ipafont package to the various
bots? Issue 665934

[Daniel Erat, 2016-11-16 21:26:40]

On 2016/11/16 20:54:58, Jack Bates wrote:
> On 2016/11/16 03:41:41, horo (JP-TOK sheriff Nov15-16) wrote:
> > A revert of this CL (patchset #3 id:40001) has been created in
> > https://codereview.chromium.org/2504863002/ by mailto:horo@chromium.org.
> > 
> > The reason for reverting is: Looks like caused many failures in
webkit_tests.
> > 
> > BUG=665693.
> 
> I think I need Infra's help adding the fonts-ipafont package to the various
> bots? Issue 665934

i haven't seen the blink failures, but if the fonts from fonts-ipafont aren't
identical to the kochi fonts, then this change may cause layout test failures,
in which case a bunch of rebaselining may be necessary. (i guess that blink
layout tests don't get run by the cq?)

[Jack Bates, 2016-11-18 15:40:50]

Description was changed from

==========
Replace kochi-*.ttf with IPA Fonts.

kochi-gothic.ttf and kochi-mincho.ttf were deprecated [1]
and dropped from Debian and Ubuntu [2].
They were replaced with ipag.ttf and ipam.ttf (fonts-ipafont package).

[1] https://packages.debian.org/wheezy/ttf-kochi-gothic
[2] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=726382#33

BUG=665515

Committed: https://crrev.com/a15698acc363af3e3b28543135e765019ef709a1
Cr-Commit-Position: refs/heads/master@{#432306}
==========

to

==========
Replace kochi-*.ttf with IPA Fonts.

kochi-gothic.ttf and kochi-mincho.ttf were deprecated [1]
and dropped from Debian and Ubuntu [2].
They were replaced with ipag.ttf and ipam.ttf (fonts-ipafont package).

[1] https://packages.debian.org/wheezy/ttf-kochi-gothic
[2] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=726382#33

BUG=665515

Committed: https://crrev.com/a15698acc363af3e3b28543135e765019ef709a1
Cr-Commit-Position: refs/heads/master@{#432306}
==========

[Jack Bates, 2016-11-18 16:00:17]

The CQ bit was checked by jack@nottheoilrig.com to run a CQ dry run

[commit-bot: I haz the power, 2016-11-18 16:01:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Jack Bates, 2016-11-18 16:46:50]

On 2016/11/16 21:26:40, Daniel Erat wrote:
> On 2016/11/16 20:54:58, Jack Bates wrote:
> > On 2016/11/16 03:41:41, horo (JP-TOK sheriff Nov15-16) wrote:
> > > A revert of this CL (patchset #3 id:40001) has been created in
> > > https://codereview.chromium.org/2504863002/ by mailto:horo@chromium.org.
> > > 
> > > The reason for reverting is: Looks like caused many failures in
> webkit_tests.
> > > 
> > > BUG=665693.
> > 
> > I think I need Infra's help adding the fonts-ipafont package to the various
> > bots? Issue 665934
> 
> i haven't seen the blink failures, but if the fonts from fonts-ipafont aren't
> identical to the kochi fonts, then this change may cause layout test failures,
> in which case a bunch of rebaselining may be necessary. (i guess that blink
> layout tests don't get run by the cq?)

I'm attempting to rebaseline the tests (by following the instructions here [1]):

> $ third_party/WebKit/Tools/Scripts/webkit-patch rebaseline-cl
> Triggering try jobs for:
>   android_blink_rel
>   linux_precise_blink_rel
>   linux_trusty_blink_rel
>   mac10.10_blink_rel
>   mac10.11_blink_rel
>   mac10.11_retina_blink_rel
>   mac10.9_blink_rel
>   win10_blink_rel
>   win7_blink_rel
> [...]
> output: ERROR: Access denied: User user:jack@nottheoilrig.com cannot add
builds to bucket master.tryserver.blink

Can you please trigger the try job for me?

[1]
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/layout_t...

[commit-bot: I haz the power, 2016-11-18 17:18:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-18 17:18:44]

Dry run: This issue passed the CQ dry run.

[msw, 2016-11-18 17:32:51]

I triggered that list of try bots for you, but I'm not familiar with this
process, so hopefully Dan or someone else can verify.

[Daniel Erat, 2016-11-18 17:37:31]

i've done the following:

- patched your change into a ToT branch using "git cl patch
https://codereview.chromium.org/2500063003/"

- started try jobs using the following:

git cl try -m tryserver.blink \
  -b linux_precise_blink_dbg \
  -b linux_precise_blink_compile_dbg \
  -b linux_precise_blink_compile_rel \
  -b linux_precise_blink_rel \
  -b linux_trusty_blink_dbg \
  -b linux_trusty_blink_compile_dbg \
  -b linux_trusty_blink_compile_rel \
  -b linux_trusty_blink_rel \
  -b mac10.9_blink_dbg \
  -b mac10.9_blink_compile_dbg \
  -b mac10.9_blink_compile_rel \
  -b mac10.9_blink_rel \
  -b win7_blink_dbg \
  -b win7_blink_compile_dbg \
  -b win7_blink_compile_rel \
  -b win7_blink_rel \
  -b mac10.10_blink_rel \
  -b mac10.11_blink_rel \
  -b mac10.11_retina_blink_rel \
  -b win10_blink_rel

[Jack Bates, 2016-11-18 19:18:11]

Thank you!
I guess I can't rebaseline the tests until the fonts-ipafont package is added to
the bots (issue 665934)?
I had a quick look at the Infra repository but it's not obvious how packages get
added to bots, so I don't think I can contribute to that process?

[Daniel Erat, 2016-11-18 19:20:54]

On 2016/11/18 19:18:11, Jack Bates wrote:
> Thank you!
> I guess I can't rebaseline the tests until the fonts-ipafont package is added
to
> the bots (issue 665934)?
> I had a quick look at the Infra repository but it's not obvious how packages
get
> added to bots, so I don't think I can contribute to that process?

ah, that's probably the case. i suspect the rebaseline will need to be run again
after that.

i don't think i have access to add packages to bots, either. it's probably a
manual process -- hopefully you'll get a response on that bug.

[Jack Bates, 2016-11-19 15:35:52]

The CQ bit was checked by jack@nottheoilrig.com to run a CQ dry run

[commit-bot: I haz the power, 2016-11-19 15:35:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-19 15:39:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-19 15:39:11]

Dry run: This issue passed the CQ dry run.

[Jack Bates, 2016-11-19 15:43:32]

The CQ bit was checked by jack@nottheoilrig.com to run a CQ dry run

[commit-bot: I haz the power, 2016-11-19 15:43:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-19 15:47:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-19 15:47:10]

Dry run: This issue passed the CQ dry run.

[Jack Bates, 2016-11-19 15:54:24]

On 2016/11/18 19:20:54, Daniel Erat wrote:
> On 2016/11/18 19:18:11, Jack Bates wrote:
> > Thank you!
> > I guess I can't rebaseline the tests until the fonts-ipafont package is
added
> to
> > the bots (issue 665934)?
> > I had a quick look at the Infra repository but it's not obvious how packages
> get
> > added to bots, so I don't think I can contribute to that process?
> 
> ah, that's probably the case. i suspect the rebaseline will need to be run
again
> after that.
> 
> i don't think i have access to add packages to bots, either. it's probably a
> manual process -- hopefully you'll get a response on that bug.

The package has now been added. Can you please re-trigger the try job for me?

[Daniel Erat, 2016-11-19 16:01:27]

On 2016/11/19 15:54:24, Jack Bates wrote:
> On 2016/11/18 19:20:54, Daniel Erat wrote:
> > On 2016/11/18 19:18:11, Jack Bates wrote:
> > > Thank you!
> > > I guess I can't rebaseline the tests until the fonts-ipafont package is
> added
> > to
> > > the bots (issue 665934)?
> > > I had a quick look at the Infra repository but it's not obvious how
packages
> > get
> > > added to bots, so I don't think I can contribute to that process?
> > 
> > ah, that's probably the case. i suspect the rebaseline will need to be run
> again
> > after that.
> > 
> > i don't think i have access to add packages to bots, either. it's probably a
> > manual process -- hopefully you'll get a response on that bug.
> 
> The package has now been added. Can you please re-trigger the try job for me?

sure thing, done. (and just to mention it, i think you may need to re-upload
this change to be able to re-land it. if so, hopefully you can copy the
rebaselined files over, but let me know if that's not the case and you need the
jobs to be run for a new change as well.)

[Jack Bates, 2016-11-19 16:05:57]

On 2016/11/19 16:01:27, Daniel Erat wrote:
> On 2016/11/19 15:54:24, Jack Bates wrote:
> > On 2016/11/18 19:20:54, Daniel Erat wrote:
> > > On 2016/11/18 19:18:11, Jack Bates wrote:
> > > > Thank you!
> > > > I guess I can't rebaseline the tests until the fonts-ipafont package is
> > added
> > > to
> > > > the bots (issue 665934)?
> > > > I had a quick look at the Infra repository but it's not obvious how
> packages
> > > get
> > > > added to bots, so I don't think I can contribute to that process?
> > > 
> > > ah, that's probably the case. i suspect the rebaseline will need to be run
> > again
> > > after that.
> > > 
> > > i don't think i have access to add packages to bots, either. it's probably
a
> > > manual process -- hopefully you'll get a response on that bug.
> > 
> > The package has now been added. Can you please re-trigger the try job for
me?
> 
> sure thing, done. (and just to mention it, i think you may need to re-upload
> this change to be able to re-land it. if so, hopefully you can copy the
> rebaselined files over, but let me know if that's not the case and you need
the
> jobs to be run for a new change as well.)

Will do. Thanks a lot for your help!

[Alexei Svitkine (slow), 2016-11-21 21:31:20]

asvitkine@chromium.org changed reviewers:
- asvitkine@chromium.org

[tonikitoo, 2016-11-23 19:42:38]

tonikitoo@igalia.com changed reviewers:
+ tonikitoo@igalia.com
- thakis@chromium.org

[Jack Bates, 2016-12-13 21:49:33]

On 2016/11/19 16:05:57, Jack Bates wrote:
> On 2016/11/19 16:01:27, Daniel Erat wrote:
> > On 2016/11/19 15:54:24, Jack Bates wrote:
> > > On 2016/11/18 19:20:54, Daniel Erat wrote:
> > > > On 2016/11/18 19:18:11, Jack Bates wrote:
> > > > > Thank you!
> > > > > I guess I can't rebaseline the tests until the fonts-ipafont package
is
> > > added
> > > > to
> > > > > the bots (issue 665934)?
> > > > > I had a quick look at the Infra repository but it's not obvious how
> > packages
> > > > get
> > > > > added to bots, so I don't think I can contribute to that process?
> > > > 
> > > > ah, that's probably the case. i suspect the rebaseline will need to be
run
> > > again
> > > > after that.
> > > > 
> > > > i don't think i have access to add packages to bots, either. it's
probably
> a
> > > > manual process -- hopefully you'll get a response on that bug.
> > > 
> > > The package has now been added. Can you please re-trigger the try job for
> me?
> > 
> > sure thing, done. (and just to mention it, i think you may need to re-upload
> > this change to be able to re-land it. if so, hopefully you can copy the
> > rebaselined files over, but let me know if that's not the case and you need
> the
> > jobs to be run for a new change as well.)
> 
> Will do. Thanks a lot for your help!

I uploaded another patch, can you please re-trigger the try job for me?
It took me a while to figure out why there were more new baselines than I
expected.
IPA Fonts and DejaVu Sans both have a glyph for "⇧". When Fontconfig sorts
fonts, it ordinarily puts DejaVu Sans before IPA Fonts, but the layout tests use
their own configuration whereby the two had equal precedence. The latest patch
fixes that, so I expect fewer new baselines.

[Daniel Erat, 2016-12-13 23:25:33]

sure, but i think you need to sync your source tree and resolve a merge conflict
in install-build-deps.sh. it looks like the following code is now present:

----

# ttf-mscorefonts-installer is in the Debian contrib repo, which has
# dependencies on non-free software.  Install it only if the user has already
# enabled contrib.
if package_exists ttf-mscorefonts-installer; then
  dev_list="${dev_list} ttf-mscorefonts-installer"
elif package_exists msttcorefonts; then
  dev_list="${dev_list} msttcorefonts"
fi

[Jack Bates, 2016-12-14 02:47:08]

On 2016/12/13 23:25:33, Daniel Erat wrote:
> sure, but i think you need to sync your source tree and resolve a merge
conflict
> in install-build-deps.sh. it looks like the following code is now present:
> 
> ----
> 
> # ttf-mscorefonts-installer is in the Debian contrib repo, which has
> # dependencies on non-free software.  Install it only if the user has already
> # enabled contrib.
> if package_exists ttf-mscorefonts-installer; then
>   dev_list="${dev_list} ttf-mscorefonts-installer"
> elif package_exists msttcorefonts; then
>   dev_list="${dev_list} msttcorefonts"
> fi

Done. I rebased the patch.

[Tom (Use chromium acct), 2016-12-14 02:48:33]

Description was changed from

==========
Replace kochi-*.ttf with IPA Fonts.

kochi-gothic.ttf and kochi-mincho.ttf were deprecated [1]
and dropped from Debian and Ubuntu [2].
They were replaced with ipag.ttf and ipam.ttf (fonts-ipafont package).

[1] https://packages.debian.org/wheezy/ttf-kochi-gothic
[2] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=726382#33

BUG=665515

Committed: https://crrev.com/a15698acc363af3e3b28543135e765019ef709a1
Cr-Commit-Position: refs/heads/master@{#432306}
==========

to

==========
Replace kochi-*.ttf with IPA Fonts. (Reland)

kochi-gothic.ttf and kochi-mincho.ttf were deprecated [1]
and dropped from Debian and Ubuntu [2].
They were replaced with ipag.ttf and ipam.ttf (fonts-ipafont package).

[1] https://packages.debian.org/wheezy/ttf-kochi-gothic
[2] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=726382#33

BUG=665515

Committed: https://crrev.com/a15698acc363af3e3b28543135e765019ef709a1
Cr-Commit-Position: refs/heads/master@{#432306}
==========

[Tom (Use chromium acct), 2016-12-14 02:48:44]

The CQ bit was checked by thomasanderson@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-12-14 02:49:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Jack Bates, 2016-12-14 03:15:20]

Patchset #6 (id:100001) has been deleted

[Daniel Erat, 2016-12-14 05:42:33]

On 2016/12/14 02:47:08, Jack Bates wrote:
> On 2016/12/13 23:25:33, Daniel Erat wrote:
> > sure, but i think you need to sync your source tree and resolve a merge
> conflict
> > in install-build-deps.sh. it looks like the following code is now present:
> > 
> > ----
> > 
> > # ttf-mscorefonts-installer is in the Debian contrib repo, which has
> > # dependencies on non-free software.  Install it only if the user has
already
> > # enabled contrib.
> > if package_exists ttf-mscorefonts-installer; then
> >   dev_list="${dev_list} ttf-mscorefonts-installer"
> > elif package_exists msttcorefonts; then
> >   dev_list="${dev_list} msttcorefonts"
> > fi
> 
> Done. I rebased the patch.

okay, i've kicked off try jobs using the same command as before. hopefully the
bot list hasn't changed...

[Jack Bates, 2016-12-14 15:16:58]

jack@nottheoilrig.com changed reviewers:
+ dpranke@chromium.org

[Jack Bates, 2016-12-14 15:27:11]

On 2016/12/14 05:42:33, Daniel Erat wrote:
> On 2016/12/14 02:47:08, Jack Bates wrote:
> > On 2016/12/13 23:25:33, Daniel Erat wrote:
> > > sure, but i think you need to sync your source tree and resolve a merge
> > conflict
> > > in install-build-deps.sh. it looks like the following code is now present:
> > > 
> > > ----
> > > 
> > > # ttf-mscorefonts-installer is in the Debian contrib repo, which has
> > > # dependencies on non-free software.  Install it only if the user has
> already
> > > # enabled contrib.
> > > if package_exists ttf-mscorefonts-installer; then
> > >   dev_list="${dev_list} ttf-mscorefonts-installer"
> > > elif package_exists msttcorefonts; then
> > >   dev_list="${dev_list} msttcorefonts"
> > > fi
> > 
> > Done. I rebased the patch.
> 
> okay, i've kicked off try jobs using the same command as before. hopefully the
> bot list hasn't changed...

Perfect, thanks! I'm reviewing the new baselines.
I added Dirk Pranke to the reviewers because I think I need an OWNER review of
fonts.conf?

dpranke@, can you please review the change to fonts.conf?

[Dirk Pranke, 2016-12-15 03:09:29]

rs- lgtm also.

[Tom (Use chromium acct), 2016-12-21 02:01:29]

Is this safe to land now?

[Jack Bates, 2016-12-21 17:01:23]

On 2016/12/21 02:01:29, Tom Anderson wrote:
> Is this safe to land now?

I'm investigating on one issue I found with one of the remaining new baselines
and one issue I found with the webkit-patch optimize-baselines tool.
This CL isn't strictly dependent on resolving those issues, but I prefer to deal
with them first, unless this CL is a higher priority.
As it stands, I plan to land this after Christmas.
Thank you for following up and for helping me!

[Dirk Pranke, 2016-12-21 18:30:40]

Apparently I wasn't paying attention at all when I first looked at this.

1) So, do these new packages exist on Precise/Trusty/Xenial/Wheezy/Jessie? 

2) As you've seen, changing the fonts will require you to change the baselines.
Are you going to do that as part of this CL?

[Jack Bates, 2016-12-21 18:42:34]

On 2016/12/21 18:30:40, Dirk Pranke wrote:
> Apparently I wasn't paying attention at all when I first looked at this.
> 
> 1) So, do these new packages exist on Precise/Trusty/Xenial/Wheezy/Jessie? 

Yes.

> 2) As you've seen, changing the fonts will require you to change the
baselines.
> Are you going to do that as part of this CL?

Yes, I plan to add the new baselines to this CL (after investigating a couple
issues I ran into).

[Dirk Pranke, 2016-12-21 18:43:14]

Sounds great! Having just hit this problem on a Xenial instance, I look forward
to the fix :).

[Tom (Use chromium acct), 2017-04-14 18:55:42]

https://codereview.chromium.org/2500063003/diff/80001/build/install-build-dep...
File build/install-build-deps.sh (right):

https://codereview.chromium.org/2500063003/diff/80001/build/install-build-dep...
build/install-build-deps.sh:336: fi
Please add "fonts-ipafont" somewhere in this file.

Then, I can reference this CL and get infra labs to install it on all bots. 
Then we can finally land this (and hopefully not break the CQ this time).

[Tom Anderson, 2017-05-18 01:16:15]

thomasanderson@chromium.org changed reviewers:
- thomasanderson@google.com

[Tom Anderson, 2017-06-05 19:37:30]

The CQ bit was checked by thomasanderson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-05 19:38:00]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-05 19:41:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-05 19:41:23]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)