Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(551)

Issue 2519543002: Revert of Disallow posting tasks to SequencedWorkerPools by default. (Closed)

Created:
4 years, 1 month ago by Fady Samuel
Modified:
4 years, 1 month ago
Reviewers:
gab, brettw, fdoray
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, jam, darin-cc_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Disallow posting tasks to SequencedWorkerPools by default. (patchset #25 id:480001 of https://codereview.chromium.org/2445763002/ ) Reason for revert: chrome --mash crashing. Original issue's description: > Disallow posting tasks to SequencedWorkerPools by default. > > We have observed crash reports in which SequencedWorkerPool workers > were active while redirection to TaskScheduler was enabled. This can > happen if a task is posted to a SequencedWorkerPool before redirection > to TaskScheduler is enabled. With this CL, DumpWithoutCrashing() is > called if a task is posted to a SequencedWorkerPool too early. This > will help us find offending call sites. > > A commented DCHECK is also added to find offending call sites. It > will be uncommented in a separate CL to avoid a revert of this CL > in case it fails on the waterfall. > > BUG=622400 > > Committed: https://crrev.com/4606ada249a240e115a08a7c66409e8fdd457ea1 > Committed: https://crrev.com/8fd22217395d50b6704109c7f1d4deff59f9a109 > Cr-Original-Commit-Position: refs/heads/master@{#432913} > Cr-Commit-Position: refs/heads/master@{#433237} TBR=gab@chromium.org,brettw@chromium.org,fdoray@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=622400 Committed: https://crrev.com/47c895a15251dde93c04721480cc9f1172d52cca Cr-Commit-Position: refs/heads/master@{#433267}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+112 lines, -155 lines) Patch
M base/test/launcher/test_launcher.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M base/test/test_suite.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M base/threading/sequenced_worker_pool.h View 2 chunks +17 lines, -23 lines 0 comments Download
M base/threading/sequenced_worker_pool.cc View 26 chunks +90 lines, -61 lines 0 comments Download
M base/threading/sequenced_worker_pool_unittest.cc View 2 chunks +3 lines, -12 lines 0 comments Download
M chrome/browser/chrome_browser_main.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/service/service_process.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M components/task_scheduler_util/initialization_util.cc View 1 chunk +1 line, -3 lines 0 comments Download
M content/browser/browser_main_loop.cc View 2 chunks +0 lines, -13 lines 0 comments Download
M content/public/test/browser_test_base.cc View 2 chunks +0 lines, -8 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 2 chunks +0 lines, -8 lines 0 comments Download
M content/renderer/render_thread_impl_browsertest.cc View 2 chunks +0 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Fady Samuel
Created Revert of Disallow posting tasks to SequencedWorkerPools by default.
4 years, 1 month ago (2016-11-18 19:34:14 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2519543002/1
4 years, 1 month ago (2016-11-18 19:35:55 UTC) #3
gab
> Reason for revert: > chrome --mash crashing. 1) Why is this not on CQ? ...
4 years, 1 month ago (2016-11-18 19:36:56 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-18 19:37:31 UTC) #5
commit-bot: I haz the power
4 years, 1 month ago (2016-11-18 19:40:18 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/47c895a15251dde93c04721480cc9f1172d52cca
Cr-Commit-Position: refs/heads/master@{#433267}

Powered by Google App Engine
This is Rietveld 408576698