Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(727)

Unified Diff: third_party/WebKit/Source/core/animation/EffectInput.cpp

Issue 2519403002: binding: Lets Dictionary::getPropertyNames, etc. rethrow an exception. (Closed)
Patch Set: Fixed DictionaryTest. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/animation/EffectInput.cpp
diff --git a/third_party/WebKit/Source/core/animation/EffectInput.cpp b/third_party/WebKit/Source/core/animation/EffectInput.cpp
index 2da614f5f0e7a4f763d7b93dc052ebdfc05962a9..46e2ff55fd632e064d7216c18a7703ec1ee4164e 100644
--- a/third_party/WebKit/Source/core/animation/EffectInput.cpp
+++ b/third_party/WebKit/Source/core/animation/EffectInput.cpp
@@ -226,7 +226,10 @@ EffectModel* EffectInput::convertArrayForm(
}
Vector<String> keyframeProperties;
- keyframeDictionary.getPropertyNames(keyframeProperties);
+ if (!keyframeDictionary.getPropertyNames(keyframeProperties,
+ exceptionState)) {
+ return nullptr;
+ }
for (const auto& property : keyframeProperties) {
if (property == "offset" || property == "composite" ||
property == "easing") {
@@ -324,7 +327,8 @@ EffectModel* EffectInput::convertObjectForm(
DictionaryHelper::get(keyframeDictionary, "composite", compositeString);
Vector<String> keyframeProperties;
- keyframeDictionary.getPropertyNames(keyframeProperties);
+ if (!keyframeDictionary.getPropertyNames(keyframeProperties, exceptionState))
+ return nullptr;
for (const auto& property : keyframeProperties) {
if (property == "offset" || property == "composite" ||
property == "easing") {

Powered by Google App Engine
This is Rietveld 408576698