binding: Lets Dictionary::getPropertyNames, etc. rethrow an exception.

third_party/WebKit/Source/modules/mediastream/MediaConstraintsImpl.cpp

Index: third_party/WebKit/Source/modules/mediastream/MediaConstraintsImpl.cpp
diff --git a/third_party/WebKit/Source/modules/mediastream/MediaConstraintsImpl.cpp b/third_party/WebKit/Source/modules/mediastream/MediaConstraintsImpl.cpp
index b0be707fb374aacb0d98ea5f5baa8524130fba7a..28fc0bb52be81b19ebcd46f1f97d681dfa324496 100644
--- a/third_party/WebKit/Source/modules/mediastream/MediaConstraintsImpl.cpp
+++ b/third_party/WebKit/Source/modules/mediastream/MediaConstraintsImpl.cpp
@@ -152,8 +152,9 @@ static bool parseMandatoryConstraintsDictionary(
     const Dictionary& mandatoryConstraintsDictionary,
     Vector<NameValueStringConstraint>& mandatory) {
   HashMap<String, String> mandatoryConstraintsHashMap;
+  TrackExceptionState exceptionState;

[haraken, 2016/11/24 07:22:31]

We should avoid using TrackExceptionState in production code. Shall we add a
TODO to fix it?

[Yuki, 2016/11/24 10:19:33]

MediaConstraintsImpl looks a little bit different.  See the call sites of this
function and APIs in MediaConstraintsImpl.

MediaContraintsImpl is intentionally using MediaErrorState, which looks similar
to ExceptionState but different.
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/modules/medias...

MediaContraintsImpl was designed to use MediaErrorState to delay an error
handling.  If parseMandatoryConstraintsDictionary() returned false, then the
call sites create an appropriate MediaErrorState.  So we don't need to have an
ExceptionState here (at least with this approach).

Thus, it seems okay for me to just use TrackExceptionState.

[haraken, 2016/11/24 12:39:13]

Okay. However, in long term I think we should replace MediaErrorState with
ExceptionState and remove TrackExceptionState though.

[Yuki, 2016/11/25 08:31:04]

Acknowledged.

   bool ok = mandatoryConstraintsDictionary.getOwnPropertiesAsStringHashMap(
-      mandatoryConstraintsHashMap);
+      mandatoryConstraintsHashMap, exceptionState);
   if (!ok)
     return false;
 
@@ -166,7 +167,8 @@ static bool parseOptionalConstraintsVectorElement(
     const Dictionary& constraint,
     Vector<NameValueStringConstraint>& optionalConstraintsVector) {
   Vector<String> localNames;
-  bool ok = constraint.getPropertyNames(localNames);
+  TrackExceptionState exceptionState;
+  bool ok = constraint.getPropertyNames(localNames, exceptionState);
   if (!ok)
     return false;
   if (localNames.size() != 1)
@@ -188,7 +190,8 @@ static bool parse(const Dictionary& constraintsDictionary,
     return true;
 
   Vector<String> names;
-  bool ok = constraintsDictionary.getPropertyNames(names);
+  TrackExceptionState exceptionState;
+  bool ok = constraintsDictionary.getPropertyNames(names, exceptionState);
   if (!ok)
     return false;