Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(510)

Unified Diff: third_party/WebKit/Source/core/testing/DictionaryTest.cpp

Issue 2519403002: binding: Lets Dictionary::getPropertyNames, etc. rethrow an exception. (Closed)
Patch Set: Addressed review comments. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/testing/DictionaryTest.cpp
diff --git a/third_party/WebKit/Source/core/testing/DictionaryTest.cpp b/third_party/WebKit/Source/core/testing/DictionaryTest.cpp
index 775378e97da415f5415af3a78302e6765ccf91e3..7ae0c0e9c6a254dbe29ebd235f3149aaa05a7879 100644
--- a/third_party/WebKit/Source/core/testing/DictionaryTest.cpp
+++ b/third_party/WebKit/Source/core/testing/DictionaryTest.cpp
@@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#include "DictionaryTest.h"
+#include "core/testing/DictionaryTest.h"
#include "bindings/core/v8/V8ObjectBuilder.h"
#include "core/testing/InternalDictionary.h"
@@ -68,10 +68,10 @@ void DictionaryTest::set(const InternalDictionary& testingDictionary) {
testingDictionary.doubleOrStringSequenceMember();
m_eventTargetOrNullMember = testingDictionary.eventTargetOrNullMember();
if (testingDictionary.hasDictionaryMember()) {
- HashMap<String, String> properties;
- testingDictionary.dictionaryMember().getOwnPropertiesAsStringHashMap(
- properties);
- m_dictionaryMemberProperties = properties;
+ NonThrowableExceptionState exceptionState;
+ m_dictionaryMemberProperties =
+ testingDictionary.dictionaryMember().getOwnPropertiesAsStringHashMap(
+ exceptionState);
}
}
« no previous file with comments | « third_party/WebKit/Source/core/animation/EffectInput.cpp ('k') | third_party/WebKit/Source/modules/fetch/Headers.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698