Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Side by Side Diff: third_party/WebKit/Source/core/testing/DictionaryTest.cpp

Issue 2519403002: binding: Lets Dictionary::getPropertyNames, etc. rethrow an exception. (Closed)
Patch Set: Addressed review comments. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "DictionaryTest.h" 5 #include "core/testing/DictionaryTest.h"
6 6
7 #include "bindings/core/v8/V8ObjectBuilder.h" 7 #include "bindings/core/v8/V8ObjectBuilder.h"
8 #include "core/testing/InternalDictionary.h" 8 #include "core/testing/InternalDictionary.h"
9 #include "core/testing/InternalDictionaryDerived.h" 9 #include "core/testing/InternalDictionaryDerived.h"
10 #include "core/testing/InternalDictionaryDerivedDerived.h" 10 #include "core/testing/InternalDictionaryDerivedDerived.h"
11 11
12 namespace blink { 12 namespace blink {
13 13
14 DictionaryTest::DictionaryTest() : m_requiredBooleanMember(false) {} 14 DictionaryTest::DictionaryTest() : m_requiredBooleanMember(false) {}
15 15
(...skipping 45 matching lines...) Expand 10 before | Expand all | Expand 10 after
61 m_objectMember = testingDictionary.objectMember(); 61 m_objectMember = testingDictionary.objectMember();
62 m_objectOrNullMemberWithDefault = 62 m_objectOrNullMemberWithDefault =
63 testingDictionary.objectOrNullMemberWithDefault(); 63 testingDictionary.objectOrNullMemberWithDefault();
64 if (testingDictionary.hasDoubleOrStringMember()) 64 if (testingDictionary.hasDoubleOrStringMember())
65 m_doubleOrStringMember = testingDictionary.doubleOrStringMember(); 65 m_doubleOrStringMember = testingDictionary.doubleOrStringMember();
66 if (testingDictionary.hasDoubleOrStringSequenceMember()) 66 if (testingDictionary.hasDoubleOrStringSequenceMember())
67 m_doubleOrStringSequenceMember = 67 m_doubleOrStringSequenceMember =
68 testingDictionary.doubleOrStringSequenceMember(); 68 testingDictionary.doubleOrStringSequenceMember();
69 m_eventTargetOrNullMember = testingDictionary.eventTargetOrNullMember(); 69 m_eventTargetOrNullMember = testingDictionary.eventTargetOrNullMember();
70 if (testingDictionary.hasDictionaryMember()) { 70 if (testingDictionary.hasDictionaryMember()) {
71 HashMap<String, String> properties; 71 NonThrowableExceptionState exceptionState;
72 testingDictionary.dictionaryMember().getOwnPropertiesAsStringHashMap( 72 m_dictionaryMemberProperties =
73 properties); 73 testingDictionary.dictionaryMember().getOwnPropertiesAsStringHashMap(
74 m_dictionaryMemberProperties = properties; 74 exceptionState);
75 } 75 }
76 } 76 }
77 77
78 void DictionaryTest::get(InternalDictionary& result) { 78 void DictionaryTest::get(InternalDictionary& result) {
79 if (m_longMember) 79 if (m_longMember)
80 result.setLongMember(m_longMember.get()); 80 result.setLongMember(m_longMember.get());
81 if (m_longMemberWithClamp) 81 if (m_longMemberWithClamp)
82 result.setLongMemberWithClamp(m_longMemberWithClamp.get()); 82 result.setLongMemberWithClamp(m_longMemberWithClamp.get());
83 if (m_longMemberWithEnforceRange) 83 if (m_longMemberWithEnforceRange)
84 result.setLongMemberWithEnforceRange(m_longMemberWithEnforceRange.get()); 84 result.setLongMemberWithEnforceRange(m_longMemberWithEnforceRange.get());
(...skipping 136 matching lines...) Expand 10 before | Expand all | Expand 10 after
221 } 221 }
222 222
223 DEFINE_TRACE(DictionaryTest) { 223 DEFINE_TRACE(DictionaryTest) {
224 visitor->trace(m_elementMember); 224 visitor->trace(m_elementMember);
225 visitor->trace(m_elementOrNullMember); 225 visitor->trace(m_elementOrNullMember);
226 visitor->trace(m_doubleOrStringSequenceMember); 226 visitor->trace(m_doubleOrStringSequenceMember);
227 visitor->trace(m_eventTargetOrNullMember); 227 visitor->trace(m_eventTargetOrNullMember);
228 } 228 }
229 229
230 } // namespace blink 230 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/animation/EffectInput.cpp ('k') | third_party/WebKit/Source/modules/fetch/Headers.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698