Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(364)

Issue 2519333005: Revert of [parser] Fix scopes in rewriting of for-of and destructuring assignments. (Closed)

Created:
4 years ago by Michael Achenbach
Modified:
4 years ago
CC:
v8-reviews_googlegroups.com, rmcilroy
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [parser] Fix scopes in rewriting of for-of and destructuring assignments. (patchset #6 id:100001 of https://codereview.chromium.org/2520883002/ ) Reason for revert: Speculative revert: Seems to break jsfunfuzz: https://build.chromium.org/p/client.v8/builders/V8%20Fuzzer/builds/14385 Original issue's description: > [parser] Fix scopes in rewriting of for-of and destructuring assignments. > > The catch scopes were created with the wrong parent scope. > > R=littledan@chromium.org > BUG=v8:5648 > > Committed: https://crrev.com/f385268d11d6da9508e481202b39f75f4b56afdd > Cr-Commit-Position: refs/heads/master@{#41222} TBR=littledan@chromium.org,verwaest@chromium.org,neis@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5648 Committed: https://crrev.com/7edbd535a9067a89137776adeac6d0d22b24ad2b Cr-Commit-Position: refs/heads/master@{#41228}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+186 lines, -270 lines) Patch
M src/ast/scopes.h View 1 chunk +0 lines, -5 lines 0 comments Download
M src/ast/scopes.cc View 1 chunk +0 lines, -30 lines 0 comments Download
M src/parsing/parser.h View 1 chunk +3 lines, -5 lines 0 comments Download
M src/parsing/parser.cc View 8 chunks +12 lines, -22 lines 0 comments Download
M src/parsing/pattern-rewriter.cc View 2 chunks +4 lines, -6 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/Generators.golden View 3 chunks +167 lines, -167 lines 0 comments Download
D test/mjsunit/regress/regress-5648.js View 1 chunk +0 lines, -35 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Michael Achenbach
Created Revert of [parser] Fix scopes in rewriting of for-of and destructuring assignments.
4 years ago (2016-11-23 15:22:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2519333005/1
4 years ago (2016-11-23 15:22:53 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-23 15:23:11 UTC) #6
commit-bot: I haz the power
4 years ago (2016-11-23 15:23:31 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7edbd535a9067a89137776adeac6d0d22b24ad2b
Cr-Commit-Position: refs/heads/master@{#41228}

Powered by Google App Engine
This is Rietveld 408576698