Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(536)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: test/cctest/interpreter/bytecode_expectations/Generators.golden

Issue 2519333005: Revert of [parser] Fix scopes in rewriting of for-of and destructuring assignments. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/parsing/pattern-rewriter.cc ('k') | test/mjsunit/regress/regress-5648.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/interpreter/bytecode_expectations/Generators.golden
diff --git a/test/cctest/interpreter/bytecode_expectations/Generators.golden b/test/cctest/interpreter/bytecode_expectations/Generators.golden
index be017d09d66cf6f6a5a226538392a5368b37ea11..d0e8419b61a20e68249996d5860e57a34ee16482 100644
--- a/test/cctest/interpreter/bytecode_expectations/Generators.golden
+++ b/test/cctest/interpreter/bytecode_expectations/Generators.golden
@@ -275,65 +275,65 @@
function* f() { for (let x of [42]) yield x }
f();
"
-frame size: 17
+frame size: 18
parameter count: 1
bytecode array length: 783
bytecodes: [
B(Ldar), R(new_target),
B(JumpIfUndefined), U8(28),
B(ResumeGenerator), R(new_target),
- B(Star), R(3),
- B(LdaZero),
- B(TestEqualStrict), R(3), U8(0),
+ B(Star), R(4),
+ B(LdaZero),
+ B(TestEqualStrict), R(4), U8(0),
B(JumpIfTrue), U8(60),
B(LdaSmi), U8(1),
- B(TestEqualStrict), R(3), U8(0),
+ B(TestEqualStrict), R(4), U8(0),
B(JumpIfTrueConstant), U8(3),
B(LdaSmi), U8(77),
+ B(Star), R(5),
+ B(CallRuntime), U16(Runtime::kAbort), R(5), U8(1),
+ B(LdaSmi), U8(-2),
B(Star), R(4),
- B(CallRuntime), U16(Runtime::kAbort), R(4), U8(1),
- B(LdaSmi), U8(-2),
- B(Star), R(3),
B(CreateFunctionContext), U8(9),
B(PushContext), R(0),
B(Ldar), R(this),
B(StaCurrentContextSlot), U8(4),
/* 11 E> */ B(StackCheck),
- B(Mov), R(context), R(6),
+ B(Mov), R(context), R(7),
B(LdaCurrentContextSlot), U8(4),
- B(Star), R(8),
- B(Mov), R(closure), R(7),
- /* 11 E> */ B(CallRuntime), U16(Runtime::kCreateJSGeneratorObject), R(7), U8(2),
+ B(Star), R(9),
+ B(Mov), R(closure), R(8),
+ /* 11 E> */ B(CallRuntime), U16(Runtime::kCreateJSGeneratorObject), R(8), U8(2),
B(StaCurrentContextSlot), U8(5),
- B(Star), R(7),
+ B(Star), R(8),
B(LdaCurrentContextSlot), U8(5),
- B(Star), R(8),
- B(LdaZero),
- B(SuspendGenerator), R(8),
- B(Ldar), R(7),
+ B(Star), R(9),
+ B(LdaZero),
+ B(SuspendGenerator), R(9),
+ B(Ldar), R(8),
/* 44 S> */ B(Return),
B(LdaSmi), U8(-2),
- B(Star), R(3),
- B(CallRuntime), U16(Runtime::k_GeneratorGetInputOrDebugPos), R(8), U8(1),
- B(Star), R(9),
- B(CallRuntime), U16(Runtime::k_GeneratorGetResumeMode), R(8), U8(1),
+ B(Star), R(4),
+ B(CallRuntime), U16(Runtime::k_GeneratorGetInputOrDebugPos), R(9), U8(1),
B(Star), R(10),
- B(LdaZero),
- B(TestEqualStrict), R(10), U8(0),
+ B(CallRuntime), U16(Runtime::k_GeneratorGetResumeMode), R(9), U8(1),
+ B(Star), R(11),
+ B(LdaZero),
+ B(TestEqualStrict), R(11), U8(0),
B(JumpIfTrue), U8(32),
B(LdaSmi), U8(2),
- B(TestEqualStrict), R(10), U8(0),
+ B(TestEqualStrict), R(11), U8(0),
B(JumpIfTrue), U8(22),
B(Jump), U8(2),
B(LdaTrue),
- B(Star), R(12),
- B(Mov), R(9), R(11),
- B(CallRuntime), U16(Runtime::k_CreateIterResultObject), R(11), U8(2),
- B(Star), R(5),
- B(LdaZero),
- B(Star), R(4),
+ B(Star), R(13),
+ B(Mov), R(10), R(12),
+ B(CallRuntime), U16(Runtime::k_CreateIterResultObject), R(12), U8(2),
+ B(Star), R(6),
+ B(LdaZero),
+ B(Star), R(5),
B(JumpConstant), U8(19),
- B(Ldar), R(9),
+ B(Ldar), R(10),
/* 11 E> */ B(Throw),
B(Ldar), R(closure),
B(CreateBlockContext), U8(0),
@@ -342,44 +342,44 @@
B(StaCurrentContextSlot), U8(4),
B(LdaZero),
B(StaContextSlot), R(1), U8(9), U8(0),
- B(Mov), R(context), R(9),
B(Mov), R(context), R(10),
+ B(Mov), R(context), R(11),
/* 30 S> */ B(CreateArrayLiteral), U8(1), U8(0), U8(9),
- B(Star), R(12),
+ B(Star), R(13),
B(LdaConstant), U8(2),
- /* 30 E> */ B(LdaKeyedProperty), R(12), U8(4),
- B(Star), R(11),
- /* 30 E> */ B(CallProperty), R(11), R(12), U8(1), U8(2),
+ /* 30 E> */ B(LdaKeyedProperty), R(13), U8(4),
+ B(Star), R(12),
+ /* 30 E> */ B(CallProperty), R(12), R(13), U8(1), U8(2),
/* 30 E> */ B(StaContextSlot), R(1), U8(7), U8(0),
B(LdaSmi), U8(-2),
- B(TestEqual), R(3), U8(0),
+ B(TestEqual), R(4), U8(0),
B(JumpIfTrue), U8(18),
B(LdaSmi), U8(1),
- B(TestEqualStrict), R(3), U8(0),
+ B(TestEqualStrict), R(4), U8(0),
B(JumpIfTrueConstant), U8(8),
B(LdaSmi), U8(77),
- B(Star), R(11),
- B(CallRuntime), U16(Runtime::kAbort), R(11), U8(1),
+ B(Star), R(12),
+ B(CallRuntime), U16(Runtime::kAbort), R(12), U8(1),
/* 27 S> */ B(LdaContextSlot), R(1), U8(7), U8(0),
+ B(Star), R(14),
+ B(LdaNamedProperty), R(14), U8(4), U8(8),
B(Star), R(13),
- B(LdaNamedProperty), R(13), U8(4), U8(8),
- B(Star), R(12),
- /* 27 E> */ B(CallProperty), R(12), R(13), U8(1), U8(6),
+ /* 27 E> */ B(CallProperty), R(13), R(14), U8(1), U8(6),
/* 27 E> */ B(StaContextSlot), R(1), U8(8), U8(0),
- B(Star), R(11),
- B(InvokeIntrinsic), U8(Runtime::k_IsJSReceiver), R(11), U8(1),
+ B(Star), R(12),
+ B(InvokeIntrinsic), U8(Runtime::k_IsJSReceiver), R(12), U8(1),
B(ToBooleanLogicalNot),
B(JumpIfFalse), U8(13),
B(LdaContextSlot), R(1), U8(8), U8(0),
- B(Star), R(11),
- B(CallRuntime), U16(Runtime::kThrowIteratorResultNotAnObject), R(11), U8(1),
+ B(Star), R(12),
+ B(CallRuntime), U16(Runtime::kThrowIteratorResultNotAnObject), R(12), U8(1),
B(LdaContextSlot), R(1), U8(8), U8(0),
- B(Star), R(11),
- B(LdaNamedProperty), R(11), U8(5), U8(10),
+ B(Star), R(12),
+ B(LdaNamedProperty), R(12), U8(5), U8(10),
B(JumpIfToBooleanTrueConstant), U8(9),
B(LdaContextSlot), R(1), U8(8), U8(0),
- B(Star), R(11),
- B(LdaNamedProperty), R(11), U8(6), U8(12),
+ B(Star), R(12),
+ B(LdaNamedProperty), R(12), U8(6), U8(12),
B(StaContextSlot), R(1), U8(10), U8(0),
B(LdaSmi), U8(2),
B(StaContextSlot), R(1), U8(9), U8(0),
@@ -394,215 +394,215 @@
B(LdaContextSlot), R(1), U8(6), U8(0),
B(StaCurrentContextSlot), U8(4),
/* 36 S> */ B(LdaCurrentContextSlot), U8(4),
- B(Star), R(11),
+ B(Star), R(12),
B(LdaFalse),
- B(Star), R(12),
- B(CallRuntime), U16(Runtime::k_CreateIterResultObject), R(11), U8(2),
- B(Star), R(11),
+ B(Star), R(13),
+ B(CallRuntime), U16(Runtime::k_CreateIterResultObject), R(12), U8(2),
+ B(Star), R(12),
B(LdaContextSlot), R(1), U8(5), U8(0),
- B(Star), R(12),
- B(LdaSmi), U8(1),
- B(SuspendGenerator), R(12),
- B(Ldar), R(11),
+ B(Star), R(13),
+ B(LdaSmi), U8(1),
+ B(SuspendGenerator), R(13),
+ B(Ldar), R(12),
/* 44 S> */ B(Return),
B(LdaSmi), U8(-2),
- B(Star), R(3),
- B(CallRuntime), U16(Runtime::k_GeneratorGetInputOrDebugPos), R(12), U8(1),
- B(Star), R(13),
- B(CallRuntime), U16(Runtime::k_GeneratorGetResumeMode), R(12), U8(1),
+ B(Star), R(4),
+ B(CallRuntime), U16(Runtime::k_GeneratorGetInputOrDebugPos), R(13), U8(1),
B(Star), R(14),
- B(LdaZero),
- B(TestEqualStrict), R(14), U8(0),
+ B(CallRuntime), U16(Runtime::k_GeneratorGetResumeMode), R(13), U8(1),
+ B(Star), R(15),
+ B(LdaZero),
+ B(TestEqualStrict), R(15), U8(0),
B(JumpIfTrue), U8(44),
B(LdaSmi), U8(2),
- B(TestEqualStrict), R(14), U8(0),
+ B(TestEqualStrict), R(15), U8(0),
B(JumpIfTrue), U8(34),
B(Jump), U8(2),
B(LdaTrue),
- B(Star), R(16),
- B(Mov), R(13), R(15),
- B(CallRuntime), U16(Runtime::k_CreateIterResultObject), R(15), U8(2),
- B(PopContext), R(2),
- B(PopContext), R(2),
- B(PopContext), R(2),
- B(PopContext), R(2),
- B(PopContext), R(2),
- B(PopContext), R(2),
- B(Star), R(8),
- B(LdaZero),
- B(Star), R(7),
+ B(Star), R(17),
+ B(Mov), R(14), R(16),
+ B(CallRuntime), U16(Runtime::k_CreateIterResultObject), R(16), U8(2),
+ B(PopContext), R(2),
+ B(PopContext), R(2),
+ B(PopContext), R(2),
+ B(PopContext), R(2),
+ B(PopContext), R(2),
+ B(PopContext), R(2),
+ B(Star), R(9),
+ B(LdaZero),
+ B(Star), R(8),
B(Jump), U8(74),
- B(Ldar), R(13),
+ B(Ldar), R(14),
/* 36 E> */ B(Throw),
B(PopContext), R(2),
B(LdaZero),
B(StaContextSlot), R(1), U8(9), U8(0),
B(Wide), B(JumpLoop), U16(-221), U16(0),
B(Jump), U8(44),
- B(Star), R(11),
+ B(Star), R(12),
B(Ldar), R(closure),
- B(CreateCatchContext), R(11), U8(10), U8(11),
+ B(CreateCatchContext), R(12), U8(10), U8(11),
+ B(Star), R(11),
+ B(PushContext), R(2),
+ B(LdaContextSlot), R(0), U8(9), U8(0),
+ B(Star), R(12),
+ B(LdaSmi), U8(2),
+ B(TestEqualStrict), R(12), U8(14),
+ B(JumpIfFalse), U8(8),
+ B(LdaSmi), U8(1),
+ B(StaContextSlot), R(0), U8(9), U8(0),
+ B(LdaCurrentContextSlot), U8(4),
+ B(Star), R(12),
+ B(CallRuntime), U16(Runtime::kReThrow), R(12), U8(1),
+ B(PopContext), R(2),
+ B(LdaSmi), U8(-1),
+ B(Star), R(8),
+ B(Jump), U8(8),
+ B(Star), R(9),
+ B(LdaSmi), U8(1),
+ B(Star), R(8),
+ B(LdaTheHole),
+ B(SetPendingMessage),
B(Star), R(10),
- B(PushContext), R(2),
B(LdaContextSlot), R(1), U8(9), U8(0),
B(Star), R(11),
- B(LdaSmi), U8(2),
- B(TestEqualStrict), R(11), U8(14),
- B(JumpIfFalse), U8(8),
- B(LdaSmi), U8(1),
- B(StaContextSlot), R(1), U8(9), U8(0),
- B(LdaCurrentContextSlot), U8(4),
- B(Star), R(11),
- B(CallRuntime), U16(Runtime::kReThrow), R(11), U8(1),
- B(PopContext), R(2),
- B(LdaSmi), U8(-1),
- B(Star), R(7),
- B(Jump), U8(8),
- B(Star), R(8),
- B(LdaSmi), U8(1),
- B(Star), R(7),
- B(LdaTheHole),
- B(SetPendingMessage),
- B(Star), R(9),
- B(LdaContextSlot), R(1), U8(9), U8(0),
- B(Star), R(10),
- B(LdaZero),
- B(TestEqualStrict), R(10), U8(15),
+ B(LdaZero),
+ B(TestEqualStrict), R(11), U8(15),
B(JumpIfTrueConstant), U8(17),
B(LdaContextSlot), R(1), U8(7), U8(0),
- B(Star), R(10),
+ B(Star), R(11),
B(LdaUndefined),
- B(TestEqualStrict), R(10), U8(16),
+ B(TestEqualStrict), R(11), U8(16),
B(JumpIfTrueConstant), U8(18),
B(LdaContextSlot), R(1), U8(7), U8(0),
- B(Star), R(10),
- B(LdaNamedProperty), R(10), U8(12), U8(17),
+ B(Star), R(11),
+ B(LdaNamedProperty), R(11), U8(12), U8(17),
B(StaContextSlot), R(1), U8(11), U8(0),
B(LdaContextSlot), R(1), U8(11), U8(0),
- B(Star), R(10),
+ B(Star), R(11),
B(LdaNull),
- B(TestEqual), R(10), U8(19),
+ B(TestEqual), R(11), U8(19),
B(JumpIfFalse), U8(4),
B(JumpConstant), U8(16),
B(LdaContextSlot), R(1), U8(9), U8(0),
- B(Star), R(10),
- B(LdaSmi), U8(1),
- B(TestEqualStrict), R(10), U8(20),
+ B(Star), R(11),
+ B(LdaSmi), U8(1),
+ B(TestEqualStrict), R(11), U8(20),
B(JumpIfFalse), U8(75),
B(LdaContextSlot), R(1), U8(11), U8(0),
B(TypeOf),
- B(Star), R(10),
+ B(Star), R(11),
B(LdaConstant), U8(13),
- B(TestEqualStrict), R(10), U8(21),
+ B(TestEqualStrict), R(11), U8(21),
B(JumpIfFalse), U8(4),
B(Jump), U8(18),
B(Wide), B(LdaSmi), U16(130),
- B(Star), R(10),
+ B(Star), R(11),
B(LdaConstant), U8(14),
- B(Star), R(11),
- B(CallRuntime), U16(Runtime::kNewTypeError), R(10), U8(2),
+ B(Star), R(12),
+ B(CallRuntime), U16(Runtime::kNewTypeError), R(11), U8(2),
B(Throw),
- B(Mov), R(context), R(10),
+ B(Mov), R(context), R(11),
B(LdaContextSlot), R(1), U8(11), U8(0),
- B(Star), R(11),
+ B(Star), R(12),
B(LdaContextSlot), R(1), U8(7), U8(0),
- B(Star), R(12),
- B(InvokeIntrinsic), U8(Runtime::k_Call), R(11), U8(2),
+ B(Star), R(13),
+ B(InvokeIntrinsic), U8(Runtime::k_Call), R(12), U8(2),
B(Jump), U8(20),
- B(Star), R(11),
+ B(Star), R(12),
B(Ldar), R(closure),
- B(CreateCatchContext), R(11), U8(10), U8(15),
- B(Star), R(10),
+ B(CreateCatchContext), R(12), U8(10), U8(15),
+ B(Star), R(11),
B(LdaTheHole),
B(SetPendingMessage),
- B(Ldar), R(10),
+ B(Ldar), R(11),
B(PushContext), R(2),
B(PopContext), R(2),
B(Jump), U8(47),
B(LdaContextSlot), R(1), U8(11), U8(0),
- B(Star), R(10),
+ B(Star), R(11),
B(LdaContextSlot), R(1), U8(7), U8(0),
- B(Star), R(11),
- B(InvokeIntrinsic), U8(Runtime::k_Call), R(10), U8(2),
+ B(Star), R(12),
+ B(InvokeIntrinsic), U8(Runtime::k_Call), R(11), U8(2),
B(StaContextSlot), R(1), U8(12), U8(0),
B(LdaContextSlot), R(1), U8(12), U8(0),
- B(Star), R(10),
- B(InvokeIntrinsic), U8(Runtime::k_IsJSReceiver), R(10), U8(1),
+ B(Star), R(11),
+ B(InvokeIntrinsic), U8(Runtime::k_IsJSReceiver), R(11), U8(1),
B(JumpIfToBooleanFalse), U8(4),
B(Jump), U8(13),
B(LdaContextSlot), R(1), U8(12), U8(0),
- B(Star), R(10),
- B(CallRuntime), U16(Runtime::kThrowIteratorResultNotAnObject), R(10), U8(1),
- B(Ldar), R(9),
- B(SetPendingMessage),
- B(LdaZero),
- B(TestEqualStrict), R(7), U8(0),
+ B(Star), R(11),
+ B(CallRuntime), U16(Runtime::kThrowIteratorResultNotAnObject), R(11), U8(1),
+ B(Ldar), R(10),
+ B(SetPendingMessage),
+ B(LdaZero),
+ B(TestEqualStrict), R(8), U8(0),
B(JumpIfTrue), U8(11),
B(LdaSmi), U8(1),
- B(TestEqualStrict), R(7), U8(0),
+ B(TestEqualStrict), R(8), U8(0),
B(JumpIfTrue), U8(17),
B(Jump), U8(28),
B(PopContext), R(1),
B(PopContext), R(1),
B(LdaSmi), U8(1),
- B(Star), R(4),
- B(Mov), R(8), R(5),
+ B(Star), R(5),
+ B(Mov), R(9), R(6),
B(Jump), U8(48),
B(PopContext), R(1),
B(PopContext), R(1),
B(LdaSmi), U8(2),
- B(Star), R(4),
- B(Mov), R(8), R(5),
+ B(Star), R(5),
+ B(Mov), R(9), R(6),
B(Jump), U8(35),
B(PopContext), R(1),
B(LdaUndefined),
- B(Star), R(7),
- B(LdaTrue),
- B(Star), R(8),
- B(CallRuntime), U16(Runtime::k_CreateIterResultObject), R(7), U8(2),
- B(Star), R(5),
+ B(Star), R(8),
+ B(LdaTrue),
+ B(Star), R(9),
+ B(CallRuntime), U16(Runtime::k_CreateIterResultObject), R(8), U8(2),
+ B(Star), R(6),
B(LdaSmi), U8(3),
- B(Star), R(4),
+ B(Star), R(5),
B(Jump), U8(14),
B(LdaSmi), U8(-1),
- B(Star), R(4),
+ B(Star), R(5),
B(Jump), U8(8),
- B(Star), R(5),
+ B(Star), R(6),
B(LdaSmi), U8(4),
- B(Star), R(4),
+ B(Star), R(5),
B(LdaTheHole),
B(SetPendingMessage),
- B(Star), R(6),
+ B(Star), R(7),
B(LdaCurrentContextSlot), U8(5),
- B(Star), R(7),
- B(CallRuntime), U16(Runtime::k_GeneratorClose), R(7), U8(1),
- B(Ldar), R(6),
- B(SetPendingMessage),
- B(LdaZero),
- B(TestEqualStrict), R(4), U8(0),
+ B(Star), R(8),
+ B(CallRuntime), U16(Runtime::k_GeneratorClose), R(8), U8(1),
+ B(Ldar), R(7),
+ B(SetPendingMessage),
+ B(LdaZero),
+ B(TestEqualStrict), R(5), U8(0),
B(JumpIfTrue), U8(32),
B(LdaSmi), U8(1),
- B(TestEqualStrict), R(4), U8(0),
+ B(TestEqualStrict), R(5), U8(0),
B(JumpIfTrue), U8(28),
B(LdaSmi), U8(2),
- B(TestEqualStrict), R(4), U8(0),
+ B(TestEqualStrict), R(5), U8(0),
B(JumpIfTrue), U8(24),
B(LdaSmi), U8(3),
- B(TestEqualStrict), R(4), U8(0),
+ B(TestEqualStrict), R(5), U8(0),
B(JumpIfTrue), U8(20),
B(LdaSmi), U8(4),
- B(TestEqualStrict), R(4), U8(0),
+ B(TestEqualStrict), R(5), U8(0),
B(JumpIfTrue), U8(16),
B(Jump), U8(17),
- B(Ldar), R(5),
+ B(Ldar), R(6),
/* 44 S> */ B(Return),
- B(Ldar), R(5),
+ B(Ldar), R(6),
/* 44 S> */ B(Return),
- B(Ldar), R(5),
+ B(Ldar), R(6),
B(ReThrow),
- B(Ldar), R(5),
+ B(Ldar), R(6),
/* 44 S> */ B(Return),
- B(Ldar), R(5),
+ B(Ldar), R(6),
B(ReThrow),
B(LdaUndefined),
/* 44 S> */ B(Return),
« no previous file with comments | « src/parsing/pattern-rewriter.cc ('k') | test/mjsunit/regress/regress-5648.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698