Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2727)

Unified Diff: chrome/test/chromedriver/chrome/devtools_http_client.h

Issue 251933005: [ChromeDriver] Support mobile emulation on desktop Chrome. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/chromedriver/chrome/devtools_http_client.h
diff --git a/chrome/test/chromedriver/chrome/devtools_http_client.h b/chrome/test/chromedriver/chrome/devtools_http_client.h
index 693f0c03bcbe44286244f15e25e8cf90a7fd88ee..81d06a73ad57d3a379c8bd1a09a82a907f39a71e 100644
--- a/chrome/test/chromedriver/chrome/devtools_http_client.h
+++ b/chrome/test/chromedriver/chrome/devtools_http_client.h
@@ -17,6 +17,7 @@ namespace base {
class TimeDelta;
}
+class DeviceMetrics;
class DevToolsClient;
class NetAddress;
class Status;
@@ -64,7 +65,8 @@ class DevToolsHttpClient {
DevToolsHttpClient(
const NetAddress& address,
scoped_refptr<URLRequestContextGetter> context_getter,
- const SyncWebSocketFactory& socket_factory);
+ const SyncWebSocketFactory& socket_factory,
+ scoped_ptr<DeviceMetrics> device_metrics);
~DevToolsHttpClient();
Status Init(const base::TimeDelta& timeout);
@@ -78,6 +80,7 @@ class DevToolsHttpClient {
Status ActivateWebView(const std::string& id);
const BrowserInfo* browser_info();
+ scoped_ptr<DeviceMetrics> device_metrics_;
samuong 2014/05/09 17:58:54 This should be private, with an accessor function
sam.rawlins 2014/05/16 21:09:38 Done.
private:
Status GetVersion(std::string* browser_version, std::string* blink_version);

Powered by Google App Engine
This is Rietveld 408576698