Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4738)

Unified Diff: chrome/test/chromedriver/chrome/devtools_http_client.cc

Issue 251933005: [ChromeDriver] Support mobile emulation on desktop Chrome. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/chromedriver/chrome/devtools_http_client.cc
diff --git a/chrome/test/chromedriver/chrome/devtools_http_client.cc b/chrome/test/chromedriver/chrome/devtools_http_client.cc
index 2d380a8490ba2b4a581591b06d779e8b079ca2ff..15a4d5965df3b76efaf27926cc996ffe6c9b97f1 100644
--- a/chrome/test/chromedriver/chrome/devtools_http_client.cc
+++ b/chrome/test/chromedriver/chrome/devtools_http_client.cc
@@ -13,6 +13,7 @@
#include "base/threading/platform_thread.h"
#include "base/time/time.h"
#include "base/values.h"
+#include "chrome/test/chromedriver/chrome/device_metrics.h"
#include "chrome/test/chromedriver/chrome/devtools_client_impl.h"
#include "chrome/test/chromedriver/chrome/log.h"
#include "chrome/test/chromedriver/chrome/status.h"
@@ -67,8 +68,10 @@ const WebViewInfo* WebViewsInfo::GetForId(const std::string& id) const {
DevToolsHttpClient::DevToolsHttpClient(
const NetAddress& address,
scoped_refptr<URLRequestContextGetter> context_getter,
- const SyncWebSocketFactory& socket_factory)
- : context_getter_(context_getter),
+ const SyncWebSocketFactory& socket_factory,
+ scoped_ptr<DeviceMetrics> device_metrics)
+ : device_metrics_(device_metrics.Pass()),
+ context_getter_(context_getter),
socket_factory_(socket_factory),
server_url_("http://" + address.ToString()),
web_socket_url_prefix_(base::StringPrintf(
@@ -248,7 +251,7 @@ Status DevToolsHttpClient::CloseFrontends(const std::string& for_client_id) {
*it,
base::Bind(&FakeCloseFrontends)));
scoped_ptr<WebViewImpl> web_view(
- new WebViewImpl(*it, &browser_info_, client.Pass()));
+ new WebViewImpl(*it, &browser_info_, client.Pass(), NULL));
status = web_view->ConnectIfNecessary();
// Ignore disconnected error, because the debugger might have closed when

Powered by Google App Engine
This is Rietveld 408576698