chrome/test/chromedriver/chrome/chrome_impl.h - Issue 251933005: [ChromeDriver] Support mobile emulation on desktop Chrome.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/chromedriver/chrome/chrome_impl.h

Issue 251933005: [ChromeDriver] Support mobile emulation on desktop Chrome. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Convert Capability to mobileEmulation; add integration- and unit-tests Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/test/chromedriver/capabilities.cc ('K') | « chrome/test/chromedriver/chrome/chrome_existing_impl.cc ('k') | chrome/test/chromedriver/chrome/chrome_impl.cc » ('j') | chrome/test/chromedriver/test/webserver.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/chromedriver/chrome/chrome_impl.h

diff --git a/chrome/test/chromedriver/chrome/chrome_impl.h b/chrome/test/chromedriver/chrome/chrome_impl.h

index 01ad5963174ae8e0cfd72a3c640f9f29c791974a..c118918baf4a203d2baa77dfdf8ddbe3ca163d92 100644

--- a/chrome/test/chromedriver/chrome/chrome_impl.h

+++ b/chrome/test/chromedriver/chrome/chrome_impl.h

@@ -16,6 +16,7 @@

class AutomationExtension;

struct BrowserInfo;

+struct DeviceMetrics;

class DevToolsEventListener;

class DevToolsHttpClient;

class JavaScriptDialogManager;

@@ -43,12 +44,14 @@ class ChromeImpl : public Chrome {

ChromeImpl(

scoped_ptr<DevToolsHttpClient> client,

ScopedVector<DevToolsEventListener>& devtools_event_listeners,

- scoped_ptr<PortReservation> port_reservation);

+ scoped_ptr<PortReservation> port_reservation,

+ scoped_ptr<DeviceMetrics> device_metrics);

virtual Status QuitImpl() = 0;

bool quit_;

scoped_ptr<DevToolsHttpClient> devtools_http_client_;

+ scoped_ptr<DeviceMetrics> device_metrics_;

private:

typedef std::list<linked_ptr<WebViewImpl> > WebViewList;