Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Unified Diff: chrome/test/chromedriver/chrome/chrome_impl.cc

Issue 251933005: [ChromeDriver] Support mobile emulation on desktop Chrome. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Convert Capability to mobileEmulation; add integration- and unit-tests Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/chromedriver/chrome/chrome_impl.cc
diff --git a/chrome/test/chromedriver/chrome/chrome_impl.cc b/chrome/test/chromedriver/chrome/chrome_impl.cc
index f0b87d653af8bf53d3b3f224e91f8bf8e1afbcee..5ac2f2bedb7e815dcd27a5bc990291f7ac8a3a34 100644
--- a/chrome/test/chromedriver/chrome/chrome_impl.cc
+++ b/chrome/test/chromedriver/chrome/chrome_impl.cc
@@ -4,6 +4,7 @@
#include "chrome/test/chromedriver/chrome/chrome_impl.h"
+#include "chrome/test/chromedriver/chrome/device_metrics.h"
#include "chrome/test/chromedriver/chrome/devtools_client.h"
#include "chrome/test/chromedriver/chrome/devtools_event_listener.h"
#include "chrome/test/chromedriver/chrome/devtools_http_client.h"
@@ -83,7 +84,10 @@ Status ChromeImpl::GetWebViewIds(std::list<std::string>* web_view_ids) {
// OnConnected will fire when DevToolsClient connects later.
}
web_views_.push_back(make_linked_ptr(new WebViewImpl(
- view.id, devtools_http_client_->browser_info(), client.Pass())));
+ view.id,
+ devtools_http_client_->browser_info(),
+ client.Pass(),
+ device_metrics_.get())));
}
}
@@ -135,9 +139,11 @@ Status ChromeImpl::Quit() {
ChromeImpl::ChromeImpl(
scoped_ptr<DevToolsHttpClient> client,
ScopedVector<DevToolsEventListener>& devtools_event_listeners,
- scoped_ptr<PortReservation> port_reservation)
+ scoped_ptr<PortReservation> port_reservation,
+ scoped_ptr<DeviceMetrics> device_metrics)
: quit_(false),
devtools_http_client_(client.Pass()),
+ device_metrics_(device_metrics.Pass()),
port_reservation_(port_reservation.Pass()) {
devtools_event_listeners_.swap(devtools_event_listeners);
}

Powered by Google App Engine
This is Rietveld 408576698