Move WTF::SpinLock to base::SpinLock.

Move WTF::SpinLock to base::SpinLock.

This CL depends on https://codereview.chromium.org/2473153003 ("Move some
compiler intrinsic #defines to base/.").

This CL is a re-land of https://codereview.chromium.org/2484803003.

BUG=632441
TBR=esprehn

Committed: https://crrev.com/74db88dc263113165c33ab008028b6685e575019
Cr-Commit-Position: refs/heads/master@{#434297}

[palmer, 2016-11-21 23:29:26]

The CQ bit was checked by palmer@chromium.org to run a CQ dry run

[palmer, 2016-11-21 23:30:05]

palmer@chromium.org changed reviewers:
+ dcheng@chromium.org, esprehn@chromium.org

[commit-bot: I haz the power, 2016-11-21 23:30:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[palmer, 2016-11-21 23:30:47]

Note changes to base/BUILD.gn relative to the 1st version of this CL. I have
tested locally that without this change, I can replicate the build bot failure
that led to the revert, and that with the change it does build.

[commit-bot: I haz the power, 2016-11-22 00:12:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-22 00:12:06]

Dry run: Try jobs failed on following builders:
  chromeos_x86-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)

[dcheng, 2016-11-22 05:57:21]

On 2016/11/21 23:30:47, palmer wrote:
> Note changes to base/BUILD.gn relative to the 1st version of this CL. I have
> tested locally that without this change, I can replicate the build bot failure
> that led to the revert, and that with the change it does build.

Sorry for the trouble: mind uploading the original change as a patchset, and
then with the fixes as a separate patchset?

[palmer, 2016-11-22 19:15:38]

> Sorry for the trouble: mind uploading the original change as a patchset, and
then with the fixes as a separate patchset?

It's easier to just write the small difference here. Now:

  # SpinLock uses inline assembly that doesn't work on NaCl, and for which there
  # is no code for ARMv6.
  if (!is_nacl && (current_cpu != "arm" || arm_version >= 7)) {
    sources += [
      "synchronization/spin_lock.cc",
      "synchronization/spin_lock.h",
    ]
  }

Previously (in https://codereview.chromium.org/2484803003), this block was in
the else block of "if (is_nacl) {...":

    # Add stuff that doesn't work in NaCl.
    sources += [
      # SpinLock uses GNU-style inline assembly, which the pnacl-clang++
      # compiler doesn't allow.
      "synchronization/spin_lock.cc",
      "synchronization/spin_lock.h",
    ]

Thus, the change is that I add spin_lock.* iff it's not NaCl and, if it's ARM,
it's ARM v7 or later. Whereas previously, I added spin_lock.* as long as it
wasn't NaCl.

[dcheng, 2016-11-22 19:41:22]

rs lgtm

[palmer, 2016-11-23 20:49:19]

Description was changed from

==========
Move WTF::SpinLock to base::SpinLock.

This CL depends on https://codereview.chromium.org/2473153003 ("Move some
compiler intrinsic #defines to base/.").

This CL is a re-land of https://codereview.chromium.org/2484803003.

BUG=632441
==========

to

==========
Move WTF::SpinLock to base::SpinLock.

This CL depends on https://codereview.chromium.org/2473153003 ("Move some
compiler intrinsic #defines to base/.").

This CL is a re-land of https://codereview.chromium.org/2484803003.

BUG=632441
TBR=esprehn
==========

[palmer, 2016-11-23 20:49:52]

The CQ bit was checked by palmer@chromium.org

[palmer, 2016-11-23 20:49:53]

esprehn to TBR since the parts he approved in the previous version of this CL
have not changed.

[commit-bot: I haz the power, 2016-11-23 20:50:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-24 00:34:39]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1479934192989290, "parent_rev":
"1340a05a2a5d33fe15d1699f307744b4f21ce419", "commit_rev":
"2288c67728a0f260be3f4e30e9706f2bd238f8c8"}

[commit-bot: I haz the power, 2016-11-24 00:35:11]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-11-24 00:37:45]

Description was changed from

==========
Move WTF::SpinLock to base::SpinLock.

This CL depends on https://codereview.chromium.org/2473153003 ("Move some
compiler intrinsic #defines to base/.").

This CL is a re-land of https://codereview.chromium.org/2484803003.

BUG=632441
TBR=esprehn
==========

to

==========
Move WTF::SpinLock to base::SpinLock.

This CL depends on https://codereview.chromium.org/2473153003 ("Move some
compiler intrinsic #defines to base/.").

This CL is a re-land of https://codereview.chromium.org/2484803003.

BUG=632441
TBR=esprehn

Committed: https://crrev.com/74db88dc263113165c33ab008028b6685e575019
Cr-Commit-Position: refs/heads/master@{#434297}
==========

[commit-bot: I haz the power, 2016-11-24 00:37:46]

Patchset 1 (id:??) landed as
https://crrev.com/74db88dc263113165c33ab008028b6685e575019
Cr-Commit-Position: refs/heads/master@{#434297}